From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] media: zd1301_demod: don't check retval after our own assignemt
Date: Thu, 13 Jun 2019 17:12:56 +0100 [thread overview]
Message-ID: <add2dbb7-3036-8052-6063-2aa85c93f8b4@ideasonboard.com> (raw)
In-Reply-To: <20190613155421.16408-5-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On 13/06/2019 16:54, Wolfram Sang wrote:
> No need to check a retval after we assigned a constant to it.
With title fixed,
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/media/dvb-frontends/zd1301_demod.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/zd1301_demod.c b/drivers/media/dvb-frontends/zd1301_demod.c
> index 96adbba7a82b..bbabe6a2d4f4 100644
> --- a/drivers/media/dvb-frontends/zd1301_demod.c
> +++ b/drivers/media/dvb-frontends/zd1301_demod.c
> @@ -421,8 +421,7 @@ static int zd1301_demod_i2c_master_xfer(struct i2c_adapter *adapter,
> } else {
> dev_dbg(&pdev->dev, "unknown msg[0].len=%u\n", msg[0].len);
> ret = -EOPNOTSUPP;
> - if (ret)
> - goto err;
> + goto err;
> }
>
> return num;
>
prev parent reply other threads:[~2019-06-13 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 15:54 [PATCH 0/4] media: don't check retval after our own assignment Wolfram Sang
2019-06-13 15:54 ` [PATCH 1/4] media: cxd2820r: don't check retval after our own assignemt Wolfram Sang
2019-06-13 16:09 ` Kieran Bingham
2019-06-13 16:19 ` Wolfram Sang
2019-06-13 16:35 ` Kieran Bingham
2019-06-13 15:54 ` [PATCH 2/4] media: mn88472: " Wolfram Sang
2019-06-13 16:11 ` Kieran Bingham
2019-06-13 15:54 ` [PATCH 3/4] media: mn88473: " Wolfram Sang
2019-06-13 16:12 ` Kieran Bingham
2019-06-13 15:54 ` [PATCH 4/4] media: zd1301_demod: " Wolfram Sang
2019-06-13 16:12 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add2dbb7-3036-8052-6063-2aa85c93f8b4@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®