From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FC9C7EE31 for ; Wed, 31 May 2023 15:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234328AbjEaPRP (ORCPT ); Wed, 31 May 2023 11:17:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234271AbjEaPRF (ORCPT ); Wed, 31 May 2023 11:17:05 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838E211D; Wed, 31 May 2023 08:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=zulFnBIOvpdXzsXSodPwLCmaalOVRPPAxIcwsGbXZrU=; b=ttG6x4A+90V0zw0Y8l/vgIMO/G uRCnVZduiOSABPA65Vx4Jw8llwlvtzFL6+wWbf6g/DqKHHAiNB1QESkW88rQAccgX7Hra/ONdweIG z148paC7S7agHEWsUK332nBTWYQFgXXpmdhHw7QxAbljfg6wxg3BWvLUCVGBCsIvW1So=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1q4NZ8-00ETKT-FD; Wed, 31 May 2023 17:16:46 +0200 Date: Wed, 31 May 2023 17:16:46 +0200 From: Andrew Lunn To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: net: phy: Support external PHY xtal Message-ID: References: <20230531150340.522994-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531150340.522994-1-detlev.casanova@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 11:03:39AM -0400, Detlev Casanova wrote: > Ethernet PHYs can have external an clock that needs to be activated before > probing the PHY. > > Signed-off-by: Detlev Casanova > --- > .../devicetree/bindings/net/ethernet-phy.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 4f574532ee13..e83a33c2aa59 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -93,6 +93,16 @@ properties: > the turn around line low at end of the control phase of the > MDIO transaction. > > + clock-names: > + items: > + - const: xtal I don't think xtal is the best of names here. It generally is used as an abbreviation for crystal. And the commit message is about there not being a crystal, but an actual clock. How is this clock named on the datasheet? Andrew