From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB0FC433FF for ; Tue, 30 Jul 2019 08:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7624D206A2 for ; Tue, 30 Jul 2019 08:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731121AbfG3Isl (ORCPT ); Tue, 30 Jul 2019 04:48:41 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50336 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728432AbfG3Isl (ORCPT ); Tue, 30 Jul 2019 04:48:41 -0400 Received: by mail-wm1-f67.google.com with SMTP id v15so56332195wml.0 for ; Tue, 30 Jul 2019 01:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wubL2/vgzPA1pd7g/Ft25BpXcTqsyo1e/4gw/momGtU=; b=QNSz0aojMPG/1QtkhZtvyLVaOttoKQe4O9vCNWYayU0EpJrw8WbWPtO5nRZ/5wvf4X zonppnk6qv7rE6CfiGuJQu6NU4cvqjKE5KQRqNn9EzkDEsjvmHajt3h4vCTwSBNNWSVo hHMTjtfeOol5VIyvEduXgdXeSF4aVxRAUVNtyjKTzO7h1mV1w2WwzGG+5tQqz77DTgCO qVH+OIwofI0j+pQJCZUFnsySf/hRXCKL4jTEiQ5/ogRwZ89xeab/p+H2lGwHkmfFsl+S h2/DksohNjyDwRR5jt3ta1+fhe1QVuw3rkyQ9iZWTy/U1hSbbjDD0qhcdTeIUGidM0GV MUUw== X-Gm-Message-State: APjAAAUsquhY5Pwga3MrX/jJ2ZRLfDoQ9bpOJ0TRvMqZ8M4L8iOG1rx5 PG8j8l1jL728HkmxwgO4uKRAjkRKKfw= X-Google-Smtp-Source: APXvYqyiUPbNE/jZJSqWwOHETlXCAehk9SFPzETDwVZDm9bd+5/kuQgX8raiwe8ulQU1S0IqxtSatA== X-Received: by 2002:a7b:c0d0:: with SMTP id s16mr74366958wmh.141.1564476518833; Tue, 30 Jul 2019 01:48:38 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:29d3:6123:6d5f:2c04? ([2001:b07:6468:f312:29d3:6123:6d5f:2c04]) by smtp.gmail.com with ESMTPSA id f3sm46989185wrt.56.2019.07.30.01.48.37 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 01:48:38 -0700 (PDT) Subject: Re: [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions To: Anup Patel , Palmer Dabbelt , Paul Walmsley , Radim K Cc: Daniel Lezcano , Thomas Gleixner , Atish Patra , Alistair Francis , Damien Le Moal , Christoph Hellwig , Anup Patel , "kvm@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20190729115544.17895-1-anup.patel@wdc.com> <20190729115544.17895-5-anup.patel@wdc.com> From: Paolo Bonzini Message-ID: Date: Tue, 30 Jul 2019 10:48:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729115544.17895-5-anup.patel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/19 13:56, Anup Patel wrote: > + cntx->hstatus |= HSTATUS_SP2V; > + cntx->hstatus |= HSTATUS_SP2P; IIUC, cntx->hstatus's SP2P bit contains the guest's sstatus.SPP bit? I suggest adding a comment here, and again providing a ONE_REG interface to sstatus so that the ABI is final before RISC-V KVM is merged. What happens if the guest executes SRET? Is that EXC_SYSCALL in hedeleg? (BTW the name of SP2V and SP2P is horrible, I think HPV/HPP or HSPV/HSPP would have been clearer, but that's not your fault). Paolo > + cntx->hstatus |= HSTATUS_SPV;