From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3491C433F5 for ; Thu, 7 Apr 2022 13:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235774AbiDGNSr (ORCPT ); Thu, 7 Apr 2022 09:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiDGNSn (ORCPT ); Thu, 7 Apr 2022 09:18:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 419C7D9EA3 for ; Thu, 7 Apr 2022 06:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649337402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gxyncrlt7RLqQpANAvK4gzaM+JXpQZHWGLpD+x9q3MA=; b=ZruGkgkLI5/7H33mAlZNsJzL1gz+oyk+9vQtFuxMh6blI6Y9SkLaggz+7UeiAQ6wrNsZWt sLD5rF4/dIyNhKlfIRHBGs3ExPsl0GLn19V3p4UOd5T19VRBnIREGmNiJ/jpPMYtu8lOA5 wuGKQMlWCa1HceYdAqjjiqGOjabS8Hc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-202-RtgUFmxEMtSRUxD9_Yeing-1; Thu, 07 Apr 2022 09:16:41 -0400 X-MC-Unique: RtgUFmxEMtSRUxD9_Yeing-1 Received: by mail-ed1-f69.google.com with SMTP id e6-20020a50fb86000000b0041cbdc01b2fso2943608edq.12 for ; Thu, 07 Apr 2022 06:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Gxyncrlt7RLqQpANAvK4gzaM+JXpQZHWGLpD+x9q3MA=; b=XrQEznqYz3289sJpAa65IH0QAsKb1+AZci+2K1vBfdyIfDSO54+9skNSLuBGWU9nDu ROdTBFgVPftkR85IUe5IcZuIuXhNZYRXqXe7FcvuIqvrhMIJBaseRWxga4PthcI2xTl6 MswYc7qeM3WjcPOv/8JifVPCqFT0zbxxsm8w7MN3HCsTTjpchhooJvspPKAYd7qCETlH jjFo7o/EGd855AoBQaTMmDaGlPR5p+SYa5JQZEudpl/rVab5Yfg+WRprwBjrTHx1kw43 kpbRLxGKqkBbxvEjFZiGzNtZjB+H8C5WdmkHMjwv9F2774UzGQH+jesKWkSQHPtUHXAf 4EEQ== X-Gm-Message-State: AOAM5326mDiYPTQxI1NZi6GL8S0cDVPVAWl7mUrHUvr24DLzw/Ym98ts HmI+JK3r57QCiFM3420KzHOnAGrzPnD575zIchflaENSFbivXEEmByfSiY0PeTati7HMudGb3+a wG5lSfm1ea/cNtFG/J9XhUPYG X-Received: by 2002:aa7:cdd9:0:b0:41d:10cc:7904 with SMTP id h25-20020aa7cdd9000000b0041d10cc7904mr1448209edw.202.1649337400064; Thu, 07 Apr 2022 06:16:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSCWSdtJiIqzDwM2V1SeuLpq3+XDTTs55SIcCItVNZ2TH0esp8yd9rxn8N4YUvHnk6+VUcOQ== X-Received: by 2002:aa7:cdd9:0:b0:41d:10cc:7904 with SMTP id h25-20020aa7cdd9000000b0041d10cc7904mr1448183edw.202.1649337399863; Thu, 07 Apr 2022 06:16:39 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id k12-20020a170906054c00b006e8289dc23csm1354640eja.9.2022.04.07.06.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 06:16:38 -0700 (PDT) Message-ID: Date: Thu, 7 Apr 2022 15:16:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v5 091/104] KVM: TDX: Handle TDX PV CPUID hypercall Content-Language: en-US To: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@gmail.com, Jim Mattson , erdemaktas@google.com, Connor Kuehl , Sean Christopherson References: From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/22 20:49, isaku.yamahata@intel.com wrote: > From: Isaku Yamahata > > Wire up TDX PV CPUID hypercall to the KVM backend function. > > Signed-off-by: Isaku Yamahata > --- > arch/x86/kvm/vmx/tdx.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > index 53f59fb92dcf..f7c9170d596a 100644 > --- a/arch/x86/kvm/vmx/tdx.c > +++ b/arch/x86/kvm/vmx/tdx.c > @@ -893,6 +893,30 @@ static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu) > return 1; > } > > +static int tdx_emulate_cpuid(struct kvm_vcpu *vcpu) > +{ > + u32 eax, ebx, ecx, edx; > + > + /* EAX and ECX for cpuid is stored in R12 and R13. */ > + eax = tdvmcall_p1_read(vcpu); > + ecx = tdvmcall_p2_read(vcpu); > + > + kvm_cpuid(vcpu, &eax, &ebx, &ecx, &edx, true); > + > + /* > + * The returned value for CPUID (EAX, EBX, ECX, and EDX) is stored into > + * R12, R13, R14, and R15. > + */ > + tdvmcall_p1_write(vcpu, eax); > + tdvmcall_p2_write(vcpu, ebx); > + tdvmcall_p3_write(vcpu, ecx); > + tdvmcall_p4_write(vcpu, edx); > + > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_SUCCESS); > + > + return 1; > +} > + > static int handle_tdvmcall(struct kvm_vcpu *vcpu) > { > struct vcpu_tdx *tdx = to_tdx(vcpu); > @@ -904,6 +928,9 @@ static int handle_tdvmcall(struct kvm_vcpu *vcpu) > return tdx_emulate_vmcall(vcpu); > > switch (tdvmcall_exit_reason(vcpu)) { > + case EXIT_REASON_CPUID: > + return tdx_emulate_cpuid(vcpu); > + > default: > break; > } Reviewed-by: Paolo Bonzini but I don't think tdvmcall_*_{read,write} add much. Paolo