From: Huyadi <hu.yadi@h3c.com>
To: "'Mickaël Salaün'" <mic@digikod.net>
Cc: "jmorris@namei.org" <jmorris@namei.org>,
"serge@hallyn.com" <serge@hallyn.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
"amir73il@gmail.com" <amir73il@gmail.com>,
"brauner@kernel.org" <brauner@kernel.org>,
"avagin@google.com" <avagin@google.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"514118380@qq.com" <514118380@qq.com>,
"konstantin.meskhidze@huawei.com"
<konstantin.meskhidze@huawei.com>
Subject: 回复: [PATCH v4] selftests/landlock:Fix two build issues
Date: Tue, 23 Jan 2024 12:04:17 +0000 [thread overview]
Message-ID: <adec399e50c74b30b59480d92c431241@h3c.com> (raw)
In-Reply-To: <20240119.Ugaehae2ze5b@digikod.net>
>> Changes v3 -> v2:
>> - add helper of gettid instead of __NR_gettid
>> - add gcc/glibc version info in comments Changes v1 -> v2:
>> - fix whitespace error
>> - replace SYS_gettid with _NR_gettid
>>
>> tools/testing/selftests/landlock/fs_test.c | 5 ++++-
>> tools/testing/selftests/landlock/net_test.c | 7 ++++++-
>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/landlock/fs_test.c
>> b/tools/testing/selftests/landlock/fs_test.c
>> index 18e1f86a6234..a992cf7c0ad1 100644
>> --- a/tools/testing/selftests/landlock/fs_test.c
>> +++ b/tools/testing/selftests/landlock/fs_test.c
>> @@ -4572,7 +4572,10 @@ FIXTURE_VARIANT(layout3_fs)
>> /* clang-format off */
>> FIXTURE_VARIANT_ADD(layout3_fs, tmpfs) {
>> /* clang-format on */
>> - .mnt = mnt_tmp,
>> + .mnt = {
>> + .type = "tmpfs",
>> + .data = "size=4m,mode=700",
>> + },
>
>I requested some changes here.
>
Could you give me some inspiration how to fix it?
it looks fine to me to assign value as above, which consistent with other pseudo FS tests.
Thanks in advance.
>> .file_path = file1_s1d1,
>> };
>>
next prev parent reply other threads:[~2024-01-23 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 10:24 Hu Yadi
2024-01-19 12:31 ` Mickaël Salaün
2024-01-21 11:02 ` 回复: " Huyadi
2024-01-23 12:04 ` Huyadi [this message]
2024-01-23 15:32 ` Mickaël Salaün
2024-01-24 1:54 ` 回复: " Huyadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adec399e50c74b30b59480d92c431241@h3c.com \
--to=hu.yadi@h3c.com \
--cc=514118380@qq.com \
--cc=amir73il@gmail.com \
--cc=avagin@google.com \
--cc=brauner@kernel.org \
--cc=jmorris@namei.org \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mic@digikod.net \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®