From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9134DC4321E for ; Wed, 30 Nov 2022 08:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234304AbiK3I7l (ORCPT ); Wed, 30 Nov 2022 03:59:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234005AbiK3I7j (ORCPT ); Wed, 30 Nov 2022 03:59:39 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7AEC840901; Wed, 30 Nov 2022 00:59:37 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 30 Nov 2022 17:59:36 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id DDB52205D901; Wed, 30 Nov 2022 17:59:36 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 30 Nov 2022 17:59:36 +0900 Received: from [10.212.156.209] (unknown [10.212.156.209]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 145F8A855B; Wed, 30 Nov 2022 17:59:36 +0900 (JST) Message-ID: Date: Wed, 30 Nov 2022 17:59:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221129103509.9958-1-hayashi.kunihiko@socionext.com> <20221129103509.9958-2-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Thank you for reviewing. On 2022/11/29 23:41, Krzysztof Kozlowski wrote: > On 29/11/2022 11:35, Kunihiko Hayashi wrote: >> Add devicetree binding schema for the system controller implemented on >> Socionext Uniphier SoCs. >> >> This system controller has multiple functions such as clock control, >> reset control, internal watchdog timer, thermal management, and so on. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> .../socionext/socionext,uniphier-sysctrl.yaml | 84 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 85 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml >> new file mode 100644 >> index 000000000000..e966ce1e4b6c >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml >> @@ -0,0 +1,84 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Socionext UniPhier system controller > > As Rob's bot pointed, you need to update here examples in other > bindings, so they will pass. Otherwise it is not bisectable change. I've got it. I should also update other examples. >> + >> +maintainers: >> + - Kunihiko Hayashi >> + >> +description: |+ >> + System controller implemented on Socionext UniPhier SoCs has multiple >> + functions such as clock control, reset control, internal watchdog >> timer, >> + thermal management, and so on. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - socionext,uniphier-ld4-sysctrl >> + - socionext,uniphier-pro4-sysctrl >> + - socionext,uniphier-pro5-sysctrl >> + - socionext,uniphier-pxs2-sysctrl >> + - socionext,uniphier-ld6b-sysctrl >> + - socionext,uniphier-sld8-sysctrl >> + - socionext,uniphier-ld11-sysctrl >> + - socionext,uniphier-ld20-sysctrl >> + - socionext,uniphier-pxs3-sysctrl >> + - socionext,uniphier-nx1-sysctrl > > All of them can have children or only some? In case of this system controller, all SoCs has clock-controller, reset-controller and watchdog. However, some SoCs don't have thermal-sensor and their register addresses are reserved. >> + - socionext,uniphier-sysctrl >> + - const: simple-mfd >> + - const: syscon >> + >> + reg: >> + maxItems: 1 >> + >> +patternProperties: >> + "^clock-controller(@[0-9a-f]+)?$": >> + $ref: /schemas/clock/socionext,uniphier-clock.yaml# >> + >> + "^reset-controller(@[0-9a-f]+)?$": >> + $ref: /schemas/reset/socionext,uniphier-reset.yaml# >> + >> + "^watchdog(@[0-9a-f]+)?$": >> + $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml# >> + >> + "^thermal-sensor(@[0-9a-f]+)?$": >> + $ref: /schemas/thermal/socionext,uniphier-thermal.yaml# >> + Thank you, --- Best Regards Kunihiko Hayashi