From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95FF1E810B1 for ; Wed, 27 Sep 2023 09:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbjI0JO6 (ORCPT ); Wed, 27 Sep 2023 05:14:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbjI0JO4 (ORCPT ); Wed, 27 Sep 2023 05:14:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16A1FA3 for ; Wed, 27 Sep 2023 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695806051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/bCjD93zGx7k6DS0sd/nFhrwYQMV95Gpv7IoiMJVN0=; b=etuxdj4ICwxAGabm39B0Roqb6V2gWvmfGJxublkuWQ0tM9zwpx2y3xl6r2mzOkLORcJ5No G/O0w+GfEJUP6P1i3NVpYGZoxanNHQdKGnFEADGNz9zU9z8svyuzXhc4fAjW0Jqjy2+cIH on37CfhZgC9E8+kDGrpZYmhiY66XEO8= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-vcLZHuyLM32YSRaYszbXuQ-1; Wed, 27 Sep 2023 05:14:09 -0400 X-MC-Unique: vcLZHuyLM32YSRaYszbXuQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-993d7ca4607so904645666b.1 for ; Wed, 27 Sep 2023 02:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695806048; x=1696410848; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T/bCjD93zGx7k6DS0sd/nFhrwYQMV95Gpv7IoiMJVN0=; b=VPkluMcUFwqHYHUcfTby/8R+ZisHpdCTNMPXk9AVmSnraZSd9DwF5YIxyhvytFL4cV i+cbopcz/sW8dBmzuyBVIKqj4MR5XisgIVokRjEQgY9R9Eab1LY1Yrl3RDI5dZpzBGoV +H7uZVG4zOnxXCNCkWfQQHr2PdYi9l5WA4BUGOwerdaGCF/mGg12X0eFcisjVBT0Vd3P ceIhJmEGjxAuZdz1HWgM5c2hge/4LOcBkms2ACxrcmRdJxo6ABNT4Z73dM/bUtL/BVRy rnF5BAD4I1GHer2Sm8eO4BeAhViTr1XrRtn1F5L6vKoXTdfrQS9MfHosJy9lj1xHD81o Fxpw== X-Gm-Message-State: AOJu0Yzjbzzrnbylz3tPlHuCN0xST7TT0MxllWlXfWqKH1OWpHns/CS/ 010/SDnVQMuEoxFTnT2vaOdzJzSATUYpyREvrxEES4swcZsH+JZf9szCo848S71oo8lMPDfVL2E tvUHtFEjVOX7bJQH5iB/lEfuq X-Received: by 2002:a17:907:1ca1:b0:9a1:bd33:4389 with SMTP id nb33-20020a1709071ca100b009a1bd334389mr1744708ejc.74.1695806048738; Wed, 27 Sep 2023 02:14:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBja2h6H4iNhc0j95Q0ZZoVn1HywvIdObcsejBA4MbQ5G7O+fTuE/uCPp8hyYYFBBIWF65Tg== X-Received: by 2002:a17:907:1ca1:b0:9a1:bd33:4389 with SMTP id nb33-20020a1709071ca100b009a1bd334389mr1744683ejc.74.1695806048395; Wed, 27 Sep 2023 02:14:08 -0700 (PDT) Received: from [192.168.1.217] ([109.36.155.235]) by smtp.gmail.com with ESMTPSA id e8-20020a170906374800b009920e9a3a73sm8972076ejc.115.2023.09.27.02.14.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 02:14:06 -0700 (PDT) Message-ID: Date: Wed, 27 Sep 2023 11:14:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFT PATCH 2/4] platform/x86: int3472: led: don't use gpiod_toggle_active_low() Content-Language: en-US To: Bartosz Golaszewski , Andy Shevchenko Cc: Mika Westerberg , Linus Walleij , Daniel Scally , Mark Gross , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski References: <20230926145943.42814-1-brgl@bgdev.pl> <20230926145943.42814-3-brgl@bgdev.pl> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI, On 9/27/23 09:02, Bartosz Golaszewski wrote: > On Tue, Sep 26, 2023 at 5:27 PM Andy Shevchenko > wrote: >> >> On Tue, Sep 26, 2023 at 04:59:41PM +0200, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Instead of acpi_get_and_request_gpiod() + gpiod_toggle_active_low(), use >>> temporary lookup tables with appropriate lookup flags. >> >> ... >> >>> + int3472->pled.gpio = skl_int3472_gpiod_get_from_temp_lookup( >>> + int3472->dev, path, agpio->pin_table[0], >>> + "int3472,privacy-led", polarity, >>> + GPIOD_OUT_LOW); >> >> Personally I found this style weird. I prefer to have longer line over >> the split on the parentheses. >> > > I in turn prefer this one. Checkpatch doesn't complain either way so > I'll leave it to the maintainers of this driver to decide. I'm fine with keeping this as is, using longer lines does not seem to make things better here. Regards, Hans