Re: [PATCH 3/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI PAI

[Liu Ying <victor.liu@nxp.com>]

On 07/23/2025, Shengjiu Wang wrote:
> On Tue, Jul 22, 2025 at 3:16 PM Liu Ying <victor.liu@nxp.com> wrote:
>>
>> Hi Shengjiu,
>>
>> On 07/18/2025, Shengjiu Wang wrote:
>>> Add binding for the i.MX8MP HDMI parallel Audio interface block.
>>> As this port is linked to imx8mp-hdmi-tx, add port@2 in
>>> fsl,imx8mp-hdmi-tx.yaml document.
>>>
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>>> ---
>>>  .../display/bridge/fsl,imx8mp-hdmi-tx.yaml    | 13 ++++
>>>  .../display/imx/fsl,imx8mp-hdmi-pai.yaml      | 61 +++++++++++++++++++
>>>  2 files changed, 74 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml

[...]

>>> +properties:
>>
>> In i.MX8MP TRM, HTX_PAI block diagram mentions an APB interface.
>> Does it mean a clock is needed?
> 
> The APB clock is bound with the power domain, so no need to add it here.

That depends on OS's power domain driver implementation.
From DT's point of view, the APB clock should be a property here.

> 
>>
>>> +  compatible:
>>> +    const: fsl,imx8mp-hdmi-pai
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>> +  port:
>>> +    $ref: /schemas/graph.yaml#/properties/port
>>> +    description: Output to the HDMI TX controller.
>>> +    unevaluatedProperties: false
>>
>> Why do you need this line?
> 
> per my understanding, this line can be added or removed.

I'd choose to drop it :)

[...]

-- 
Regards,
Liu Ying