Re: [PATCH v2] arm64: dts: ti: k3-pinctrl: Add virtual GPIO select mux macros

[Akashdeep Kaur <a-kaur@ti.com>]

Hi Nishanth,

On 21/09/26 23:13, Nishanth Menon wrote:
> On 12:05-20260921, Akashdeep Kaur wrote:
>> Add virtual GPIO select mux macros for configuring the vgpio_sel
...
>> @@ -3,11 +3,12 @@
>>    * This header provides constants for pinctrl bindings for TI's K3 SoC
>>    * family.
>>    *
>> - * Copyright (C) 2018-2025 Texas Instruments Incorporated - https://www.ti.com/
>> + * Copyright (C) 2018-2026 Texas Instruments Incorporated - https://www.ti.com/
> 
> Drop this for trivial changes.

Done
> 
>>    */
>>   #ifndef DTS_ARM64_TI_K3_PINCTRL_H
>>   #define DTS_ARM64_TI_K3_PINCTRL_H
>>   
>> +#define VGPIO_SEL_SHIFT         (4)
> 
> Tabs like the rest of the macros? I assume checkpatch --strict didn't catch this?
> 
> Did you check *all* k3 devices to ensure the offset is the same for all
> K3? in the next revision, please add that audit in the diffstat section.

Published the audit findings in the diffstat section of v3.
No, --strict did not catch this. Thanks for the catch! Fixed
> 
>>   #define WKUP_LVL_EN_SHIFT	(7)
>>   #define WKUP_LVL_POL_SHIFT	(8)
>>   #define DEBOUNCE_SHIFT		(11)
>> @@ -111,6 +112,11 @@
>>   #define PIN_WKUP_EN_LEVEL_HIGH		(WKUP_ENABLE | WKUP_ON_LEVEL | WKUP_LEVEL_HIGH)
>>   #define PIN_WKUP_EN			(WKUP_ENABLE | WKUP_ON_EDGE)
>>   
>> +#define PIN_VGPIO_SEL0                  (0 << VGPIO_SEL_SHIFT)
>> +#define PIN_VGPIO_SEL1                  (1 << VGPIO_SEL_SHIFT)
>> +#define PIN_VGPIO_SEL2                  (2 << VGPIO_SEL_SHIFT)
>> +#define PIN_VGPIO_SEL3                  (3 << VGPIO_SEL_SHIFT)
> 
> Same - use tabs (consistent with rest of the file) - also add
> a comment above these to indicate the user should read the trm
> corresponding to the SoC for the meaning of the values - people are
> not going to do git log to know these values should be selected
> carefully based on SoC (same value means different things on different
> SoCs).
Added a comment above as recommended. Fixed to use tabs.
> 
>> +
>>   /* Default mux configuration for gpio-ranges to use with pinctrl */
>>   #define PIN_GPIO_RANGE_IOPAD	(PIN_INPUT | 7)
>>   
>> -- 
>> 2.34.1
>>
> 
Thanks and Regards,
Akashdeep Kaur