From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099D4340A6C for ; Thu, 9 Jul 2026 15:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610389; cv=none; b=LNtxRgPL/enHPt8mGbYlpedEJLA9YSO75vSRVlMBIFcSus2KGuJ0O/MTRDvViLVIjHpQ6ioIow+uqLpiK4yOoLvou5fN2EhIKpqKhrl+5QWfJCTJeVh+RKdjTSQDD/qEdcTt9jZdHxy0WVcJdrUmaFQ/OhBMNJfMxOUZyJoqtGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610389; c=relaxed/simple; bh=npVy+0H/fi2GZTA22fZIHjeF+zdwdtRfkSyBcvJZ4Rw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AVQNkpjxPskPMSDdZMl9fHOSLdDvhkUlGO+HO3xD2DTelPRpnyoTjlZT1/37lpjMtZBJXxvII4CsvfFO8WI0A4o0XqI3GemTSyNWCe3C2wLRhcIPi70V5gFaai7k+v7Yu51bw6CTFT1LTnMxHSTkNBxBwg+NmLXtUht9LKrGBiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N/M9l5aC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N/M9l5aC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B6E01F000E9; Thu, 9 Jul 2026 15:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783610387; bh=tuKCTnM+Osr3j+Lqx5Pf3G3UKrpAmsIwQxfq6IJPwvo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=N/M9l5aC2yoH0Krz0SFHjkoce3g1q9vmDuXx+jQoxmopoOx7clAfGv5TT6t5bsLE2 Z234rD0WwIyyw+r7pSwyioYQ+LBpT0FeYxE45QLLE1q7L535ZEeCGqqmxMsp3iJuyL cDubwF/UoY75gwBTOfO+E0Udvj3lkBUQMbPV6JXEIW6vq+BL2j+1ZtoqrNOcCTkY3s O37I25iTwJ0+0F9+BrZLODN+YXOggGpxNTOg4u/NiIGyjwPWFNE4QEWuLpIS4D7WCD 0QOMcEzfWHadOAmLHl6JelJsr2CrxwtFSCc3zyhu9iSfFwMKcFyTr2BwCwNULCu4sc NTgnLgPVfhZqA== Message-ID: Date: Thu, 9 Jul 2026 10:19:46 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] firmware: stratix10-rsu: Add synchronous fallback for async SVC operations Content-Language: en-US To: "NG, TZE YEE" , "linux-kernel@vger.kernel.org" Cc: "NG, ADRIAN HO YIN" , "Nazle Asmade, Muhammad Nazim Amirul" References: <69aae935f5a07649275a1b79046f5d92968a6087.1779788405.git.tze.yee.ng@altera.com> From: Dinh Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/9/26 04:13, NG, TZE YEE wrote: > On 26/5/2026 5:41 pm, NG, TZE YEE wrote: >> From: Mahesh Rao >> >> The RSU driver was migrated to the Stratix10 asynchronous service >> framework, which assumes async client registration always succeeds. On >> platforms where the async controller is unavailable or RSU async support >> is not present, probe fails or sysfs operations cannot reach firmware. >> >> Detect async capability at probe via stratix10_svc_add_async_client() and >> fall back to the legacy synchronous rsu_send_msg() path when registration >> fails. Track capability in priv->async and branch accordingly for: >> >> - Initial RSU status and retry counter during probe (retry is bundled in >> async status; issue COMMAND_RSU_RETRY separately in sync mode) >> - notify sysfs store (notify, status, and retry) >> - SPT table retrieval (COMMAND_RSU_GET_SPT_TABLE async vs mbox >> COMMAND_MBOX_SEND_CMD synchronous) >> >> Restore synchronous callbacks (rsu_status_callback, rsu_retry_callback, >> rsu_get_spt_callback) and wire COMMAND_MBOX_SEND_CMD payload handling in >> rsu_send_msg(). >> >> Improve probe and remove cleanup: return on intermediate probe failures, >> remove the async client when registered, and free the SPT response buffer >> on sync-path allocation errors. >> >> } >> > > Hi, > > Gentle ping on this patch — any chance for a review when you have time? > Happy to rebase or revise based on your feedback. > Sorry for missing this. Can you please rebase this to socfpga_firmware_for_v7.3 on my tree and I will review it. Thanks, Dinh