From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C9342D73B6 for ; Sat, 11 Jul 2026 15:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783783441; cv=none; b=jS0QGvKoXPYmflEHdMw6JmKUAqS+q8TMMkwj/2kQCBevV2Ugj/xP8+CJzJP1zvfaTLvHM96e6tA/jjHf6xasONXYmiUKXzl0g9O3MmAlzXFBNizbsp8y9ik4yTxpB76yPdX7kNRu2aIRQdJT1tRMv0kT6xgeXQlfgt+Lguj+lLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783783441; c=relaxed/simple; bh=ytnfegl7Qybj0AzCwxpuF7iUfDDtBrbX3UJyTbFECFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tg6at25xzzilt9w5EBHIqRM6EXaOFeZjwdxltn9XkGaLQn3wMht/cOW2LDxUNthpqfA0BLBihXBylRT81J2e46cGnkIqna3IzGAelu8cRPQTUfpFr/Rp5QwOAngb6mrEspZo2aTj3q8iRpvOKt1Kiukf6cdp2A4qqLN4a3oAlQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=nqfb1Qyx; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="nqfb1Qyx" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-4a427e628a9so468011b6e.0 for ; Sat, 11 Jul 2026 08:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783783439; x=1784388239; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oPASv6Zq6YY/gY0oEbRpb3fd8WBXtfv+ncRCm+l0SYU=; b=nqfb1Qyx+tiBLoFx4qCorjqcdUaW+NF5KZRAK33H7kZ7z9OBpT2CdoqglmKwIhr6tZ fSSoWlw24odf95XayfNIwzsX1U1xH0tXzESOMr8qO9pl9uaNC/ulEjUJq44DnauQr2/I XWa85atQ3G0w6JSAfHOwJrkEj3U33LN3ld5vQplda3aeDMUtlf6CRsr5QMI3AJzPlH/l hmeCwk8L7CN/6f8CaOE4kCes1iEsnXhtndLYInQAF0K2bSBO1rJReW4ZBe6RkoD9eAl/ Q9vJLfwu/D0ErSDkZug7wsF2hWICLathL8uu3Jt+CPK0P3YFovq+GBVocVUMs8TF6ti7 Emow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783783439; x=1784388239; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oPASv6Zq6YY/gY0oEbRpb3fd8WBXtfv+ncRCm+l0SYU=; b=CKqlXWgSeXtrhCXk5nXczXDrCiC2cMn50mevh2HYtoxz2d4MlJYsodL0Vbn5xSO8LX 50IsMhp9D8dS+UT+VLoOD2MY0T25uNbIrEODd4BvFntljzptZDkDmuc9f2+/1TPlR6Gf QRZfxskesDxx2TfMtEZhIyDZ2l22UYoRs6BXD/zjT70YBnoOyF1ciuQy7+8R81tKFn2y MLwdOG1i3lw9jvz8SjcnAYEKB3oBt1r4LUB0YtE1rJkGQIXhHII2TNiMiOCRLgKOJlz4 GaxnxA/TqekMTVoWG1P3Vsx4AEmHnHfmyczPr0Erpne6xmkbKVERwV5KTX4TZ1Z4Wzl4 1j+g== X-Forwarded-Encrypted: i=1; AFNElJ9eZ52tlYnGz2efEXhCTgj0vmE8DYVAkLZMOv6RO/mPoWH1WKVKdkGhLJjyNlglZkksEkG0MHTjUw0oIsM=@vger.kernel.org X-Gm-Message-State: AOJu0YxhMyhY/hxURRVdbov8urTZr+NvEF08B+FjxTXxtNZt4myA6Xg6 XagX4D3huQy6EKNd8outAN4reXRPpprvOIqjv8YV9bscXMWXn16jo52vAaNF64W7xEY= X-Gm-Gg: AfdE7ckr0KlCm+l/cHKNT3fOWhDoyiE+oesAya1sgBughwi5SpgzCSPcLsTc5BwVsXz t4ABDXwgq68xdi/N0np51pfZUvibUWOcmQ3FDMdi/Pvm1rsWgsrvganzasvTq1bbZNhpxycn84I 2RWyMbMdp0P/dPyKlXuAQLSZEs4L0QEWHs6wMDa/Z9zyS3c6Bs/ofQqAcWEjzH6nCoFPlZnFR1f TLoCepTxQYxJ3bqwcSDI40gM7OGLAnJBmm93fmbrGVZSS9VOlrYRWIbDPXrShydWMViPVL5FebR +pPdtO1MVtNVT441ghW0DSEJ/PdyI/4M8V1X/cMkbBb6b+NeZOCpxGmFPUs60w4PikH38oiFiD6 OdA7ZS16Hf8f09efklILeT+oQf/wF9AbSkEQ6ubBvRKhgH+gcPIiEpBIcWG3kurfkW/UkwK5WIY j28Gb/sZL0xCFfP1F3zVVC03bAFuZBAKkokGmShAG1V24oq4/pNWaGdSAa05yV6WQ= X-Received: by 2002:a05:6808:6903:b0:493:b6b8:c8b0 with SMTP id 5614622812f47-4a42ad7549dmr1908121b6e.14.1783783439274; Sat, 11 Jul 2026 08:23:59 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:a950:74e5:81f2:8c89? ([2600:8803:e7e4:500:a950:74e5:81f2:8c89]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1b01eefbbsm7974781b6e.13.2026.07.11.08.23.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 08:23:57 -0700 (PDT) Message-ID: Date: Sat, 11 Jul 2026 10:23:56 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/7] New features for the AD5686 IIO driver To: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Cc: Michael Hennerich , Jonathan Cameron , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" , sashiko-bot@kernel.org, Maxwell Doose , Joshua Crofts References: <20260710-ad5686-new-features-v7-0-1bcc8c280e4d@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260710-ad5686-new-features-v7-0-1bcc8c280e4d@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/10/26 6:20 AM, Rodrigo Alencar via B4 Relay wrote: > This is the second series of three on updating the AD5686 driver. > > Initially, a big patch series was sent: > https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com > > Then, the first patch series added fixes and cleanups: > https://lore.kernel.org/linux-iio/20260524-ad5686-fixes-v7-0-b6bf395d08bd@analog.com/ > > This one is introducing new features: > - Consume optional reset and correct power supplies; > - LDAC GPIO handling (active-low, held low when unused); > - SPI bus sync() implementation for batching multiple transfers; > - Triggered buffer support, leveraging LDAC and sync() to flush > all channel writes atomically; > - Gain control support through the scale property. > > Signed-off-by: Rodrigo Alencar > --- I made a few comments, but nothing critical, so... Reviewed-by: David Lechner