mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: <bp@alien8.de>, <mchehab@kernel.org>, <james.morse@arm.com>,
	<rrichter@marvell.com>, <zhengbin13@huawei.com>,
	<yi.zhang@huawei.com>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC: remove set but not used variable 'ecc_loc'
Date: Mon, 16 Dec 2019 09:11:54 +0800	[thread overview]
Message-ID: <adf6f7d0-5e92-78a0-7b2e-7252e3eec99c@huawei.com> (raw)
In-Reply-To: <20191213231117.GA793@agluck-desk2.amr.corp.intel.com>



On 2019/12/14 7:11, Luck, Tony wrote:
> On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote:
>> @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
>>   		pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
>>   		syndrome = dw2;
>>   		pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
>> -		ecc_loc = i5100_redmemb_ecc_locator(dw2);
>>   	}
>>   
>>   	if (i5100_validlog_recmemvalid(dw)) {
> 
> This deletes the only call to i5100_redmemb_ecc_locator(). Should
> we delete the definition of the function too?
Thank you for your response!
Yes, I think we can do that.

Thanks
Yu Kuai
> 
> Is it worth making cosmetic cleanups to a driver for 12 year old h/w?
> 
> -Tony
> 
> .
> 


      reply	other threads:[~2019-12-16  1:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 12:10 yu kuai
2019-12-13 23:11 ` Luck, Tony
2019-12-16  1:11   ` yukuai (C) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adf6f7d0-5e92-78a0-7b2e-7252e3eec99c@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rrichter@marvell.com \
    --cc=tony.luck@intel.com \
    --cc=yi.zhang@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®