From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E469229D294 for ; Sat, 11 Apr 2026 05:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884158; cv=none; b=QjM6PoMGsvtz92WeUo+wLro8BQc3BR1NHkO/uQjoqg3dlq+rEYPZL1Y+1pMpGYXBbJz4v5Q0aqrsGLYC4brVyGL6CksK993GbFBTv0dZajyjTPODEiB1UBJ3qCotiFmbfA8hwLrOL826+agRLRibGSTrakGoCX4EgKYCVzC1lB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884158; c=relaxed/simple; bh=tTLfxWzUWt8F3Cp4GPDJCl5DR7hUWhAcP3sdQa1XDiE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fCBiTna/1hciED4NwROOM6KKq8V5Wkls4mmnZqIkOgrXRwqtI8bWYZD84+F815nbXqTzfRn1uZP1oCJb3HPavIxyNC/TXz0gDq51srOCjfBxWpZZOEaTmJPVjzJ7aFYW+gXJQ9+ZI3VnzBbkQ8mcuhR6ZkXaPIqbsL2PaiSEu9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=EcjL6MnN; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="EcjL6MnN" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8a08fa355a1so39982576d6.0 for ; Fri, 10 Apr 2026 22:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1775884156; x=1776488956; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LnPixhfaUhNyQ4OjatQAQp1qsz8FPPMw3JjLj6a1Ycw=; b=EcjL6MnNsXC0vvYLNpkzA6/An7Acn2hfzPbSlXoGPf5ikdPXhybDshvAVEApW1GKVq 1g8ukFgmvKdvN9+COumL+z9/Ib1sceNLG61z4dbR+jp7gI3qP426EnHsEhYu25i9o8/0 6IgTPXMIFydSO6IIwT1EgC9Qwxr4V94AlcalYHKZ2gufYEIkgcp7JhyKuHeCR/2hFJJO E37agmqv+MobrZRUpZpQLemJXJ2P6I1VSLWH+FpKWCL5f2JewtMxi/j0YR6Dje3DBk+J foOIBWYOf7i/J2HMGS9sgZYLNjcZVPWryPtR4q9OFikhCj9ZCzVIxF/e98Tp25Degxdn +rOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775884156; x=1776488956; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LnPixhfaUhNyQ4OjatQAQp1qsz8FPPMw3JjLj6a1Ycw=; b=mkL/UVubEmy5PLXR/703d4t0HAOliYBK5m8huohppTHS7z2XOgYUT+2PS4gKOStnfh zwQv9S4ldY9pDrkq6c9Q028fQKkncZwKPHGMaiY/HMtWstzduAIFvuqkwujqfJW3EP+t 314VNTqnX3LWi7LOxjNPoxPu5VQhdYtVSZzhOYAmiR00gFbZPRAb3YqkqNHHSmUIBoNz lE3diBesGY3QilJC/5vmcKnnauJhgmRYL2LGwQVRTUnR0k2qj0nST/7xLsDdT1GHf5LF /nf+WLp5ZvwVXgwvfRhRXebUz3PpmKXnWVUOou5/c9ujE4rEJTT2/ixAM8t3htkczYd2 yUMA== X-Forwarded-Encrypted: i=1; AJvYcCWub+Vl4Ae/S70Dtj8XMSU/r/InpC5FJQbgG7fSlgsbWOc0a6pm858SPfg0eAb0PRpiJL+EnvvdhPoQrwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOX0gGT8IIt0w1QwNFL1kAL9Ll5Ne7b++yq4GUzOe/FuBaiYWd RKBaTAsSY/UBuycjJK4GGIbVl/ntvyq/IpbCvUvTNQ4iYKiT17fNDuPt1906MEGRyRQ= X-Gm-Gg: AeBDievULAXTEJn4RHJvzd55dJBKWEhbpm6NZQDxibCQfiBn2clw1duQzd9yxDod+n6 xvSkS1/8ULpZnnu7wVh61UVT8nXAoMVqIMYbaTfyNKvdDoTiNl800FpskbpIOrbz5LFDGimkgEJ klcARdOPqT2gdk4WXQvfCVlLw5pt7YGNLJaT/hjCjRZ4uXkEHUXkk9oI4hulXQIR8Pve1GfeZRm kyk0tTWNXzZ/Yre6TcABg3CKFQJI+OS4Vwhj9Mz+KJUkH2QGz39GF2kNQDuIZrptNLdajpOGMEN ss4SibiebVl6jvv+L39thewP7ulJOvXqv660+YN6LEL7IFcvI+0un62Drh/XVZF7i4l+SdU89mj ED6uuXRQkNZZC0AP2uZX1aclBzUCS+tzgZLW5c0JiKIRzcfM0EoF4aG2p+KBbMBq9KV1tkQOQmY q8eZtZBVHys/vcdIkGPoakkOD+mq0/HxEeYKROvjXrUkiWhDJSQ6jSF7dD+BMR8NO7GSN7BCc0r P1jbf/9xVgs X-Received: by 2002:a05:6214:2601:b0:8a0:7c8:4098 with SMTP id 6a1803df08f44-8ac86157f1bmr95391296d6.6.1775884155794; Fri, 10 Apr 2026 22:09:15 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-71-191-243-150.washdc.fios.verizon.net. [71.191.243.150]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84c4acd5sm38932846d6.23.2026.04.10.22.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:09:15 -0700 (PDT) Date: Sat, 11 Apr 2026 01:09:13 -0400 From: Gregory Price To: Anisa Su Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: Re: [PATCH v5 2/3] cxl/core/region: move dax region device logic into region_dax.c Message-ID: References: <20260327020203.876122-1-gourry@gourry.net> <20260327020203.876122-3-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 10, 2026 at 05:02:00PM -0700, Anisa Su wrote: > > + > > + cxlr_dax->hpa_range.start = p->res->start; > > + cxlr_dax->hpa_range.end = p->res->end; > > + > > + dev = &cxlr_dax->dev; > > + cxlr_dax->cxlr = cxlr; > cxlr->cxlr_dax = cxlr_dax; > > Running into segfaults without this ^ This should have been a purely non-functional change (the code is just moving from A to B without changes). That would mean the original code should run into this too unless I mucked up the move. ~Gregory