From: Frank Li <Frank.li@nxp.com>
To: Stanley Chu <stanley.chuys@gmail.com>
Cc: miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com
Subject: Re: [PATCH v1 1/2] i3c: master: svc: Fix missed IBI after false SLVSTART on NPCM845
Date: Sun, 12 Apr 2026 21:16:07 -0400 [thread overview]
Message-ID: <adxD10wsP7hJdR9y@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260413005040.1211107-2-yschu@nuvoton.com>
On Mon, Apr 13, 2026 at 08:50:39AM +0800, Stanley Chu wrote:
> From: Stanley Chu <yschu@nuvoton.com>
>
> The NPCM845 I3C controller may raise a false SLVSTART interrupt. The
> handler first latches MSTATUS and then clears SLVSTART. If a real IBI
> request arrives after the handler latches MSTATUS but before it clears
> the SLVSTART interrupt status,
How this happen? If irq handler running, hardware (real IBI) will trigger
irq line before it.
Do you enable other type irq?
Frank
> HW sets the SLVREQ state. However, the
> handler still relies on the stale MSTATUS snapshot, returns early, and
> misses the real IBI. No further interrupt is generated for this pending
> IBI.
>
> Re-read MSTATUS to obtain the latest state and avoid missing a real IBI
> due to this race condition.
>
> Fixes: 4dd12e944f07 ("i3c: master: svc: Fix npcm845 invalid slvstart event")
> Signed-off-by: Stanley Chu <yschu@nuvoton.com>
> ---
> drivers/i3c/master/svc-i3c-master.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b84b324e4111..7d88e8fe3742 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -672,10 +672,18 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)
> /* Clear the interrupt status */
> writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS);
>
> - /* Ignore the false event */
> - if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) &&
> - !SVC_I3C_MSTATUS_STATE_SLVREQ(active))
> - return IRQ_HANDLED;
> + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART)) {
> + /*
> + * Re-read MSTATUS to obtain the latest state and avoid
> + * missing an IBI that arrives after MSTATUS is latched
> + * but before SLVSTART is cleared.
> + */
> + active = readl(master->regs + SVC_I3C_MSTATUS);
> +
> + /* Ignore the false event */
> + if (!SVC_I3C_MSTATUS_STATE_SLVREQ(active))
> + return IRQ_HANDLED;
> + }
>
> /*
> * The SDA line remains low until the request is processed.
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-04-13 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 0:50 [PATCH v1 0/2] i3c: master: svc: Fix false SLVSTART issues " Stanley Chu
2026-04-13 0:50 ` [PATCH v1 1/2] i3c: master: svc: Fix missed IBI after false SLVSTART " Stanley Chu
2026-04-13 1:16 ` Frank Li [this message]
2026-04-13 1:40 ` Stanley Chu
2026-04-13 3:00 ` Frank Li
2026-04-13 3:59 ` Stanley Chu
2026-04-22 9:19 ` Frank Li
2026-04-13 0:50 ` [PATCH v1 2/2] i3c: master: svc: Prevent IRQ storm from " Stanley Chu
2026-04-22 9:20 ` Frank Li
2026-04-30 10:01 ` [PATCH v1 0/2] i3c: master: svc: Fix false SLVSTART issues " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adxD10wsP7hJdR9y@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=kwliu@nuvoton.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=stanley.chuys@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=yschu@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®