From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA6E8358385 for ; Mon, 13 Apr 2026 10:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074625; cv=none; b=RANxlBifKA6TwDj2FuxHWlZIfIfuh1720i+kFCnqn/nOidBIaD1mif5KwA4JFPpHXgOBtiFr6vcBOVm+64NfYDqOSRyLSfnsVy7+T+diqDenNUFqlM30k1E1HnWfFda3q5PdkDmRFiiLWlWaXbHtRhXyU5Ss2zV5IjKqBjtPGWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074625; c=relaxed/simple; bh=+WaVpOKRK+c+itVGcTa/pCcJblWYON1rar2wLjXPz1o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IckrC60lSqpgYi++AA3nZEU+GMe2JdZudLmZEF6tfRxLcFG05qJ0WIbGpTONULPPVTVuzcIbUw5qUfj5Bgb89a+Ei0HNolVffCxzLndmWWMVr4X95XpkiWoUyzIk0/s//WMQEZ9jkjSfM2suRBeiCahjySJsvb0U/IRbvLWGJd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=IXjv3UuM; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="IXjv3UuM" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74E1935A7; Mon, 13 Apr 2026 03:03:37 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6FF93F641; Mon, 13 Apr 2026 03:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776074623; bh=+WaVpOKRK+c+itVGcTa/pCcJblWYON1rar2wLjXPz1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXjv3UuMd85iVJ0wKfIAOskwb4linlNWUTK9e6jYgaPazUtzzNW7YpexoWr/YL74b zFSySfUpK4ZxqUA/DNJTUHCQKhyrZWx8f9ZP3XSPFlOOd3VkP8I52Dec0fp7SbCZyt s24seek5kKSsBBXK6pLbVlEmVC6g5HUdbIt18aYk= Date: Mon, 13 Apr 2026 11:03:39 +0100 From: Yeoreum Yun To: Jie Gan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com Subject: Re: [PATCH v3 1/5] coresight: etm4x: introduce struct etm4_caps Message-ID: References: <20260412175506.412301-1-yeoreum.yun@arm.com> <20260412175506.412301-2-yeoreum.yun@arm.com> <6ed0ee60-caa2-4a76-9e01-5d2b8c9af701@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ed0ee60-caa2-4a76-9e01-5d2b8c9af701@oss.qualcomm.com> Hi Jie, > > Hi Yeoreum, > > On 4/13/2026 1:55 AM, Yeoreum Yun wrote: > > introduce struct etm4_caps to describe ETMv4 capabilities > > and move capabilities information into it. > > > > Signed-off-by: Yeoreum Yun > > --- > > .../coresight/coresight-etm4x-core.c | 234 +++++++++--------- > > .../coresight/coresight-etm4x-sysfs.c | 190 ++++++++------ > > drivers/hwtracing/coresight/coresight-etm4x.h | 175 ++++++------- > > 3 files changed, 327 insertions(+), 272 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > > index d565a73f0042..6443f3717b37 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > > <...> > > > +/** > > + * struct etmv4_caps - specifics ETM capabilities > > + * @nr_pe: The number of processing entity available for tracing. > > + * @nr_pe_cmp: The number of processing entity comparator inputs that are > > + * available for tracing. > > + * @nr_addr_cmp:Number of pairs of address comparators available > > + * as found in ETMIDR4 0-3. > > + * @nr_cntr: Number of counters as found in ETMIDR5 bit 28-30. > > + * @nr_ext_inp: Number of external input. > > + * @numcidc: Number of contextID comparators. > > @numextinsel: > > > + * @numvmidc: Number of VMID comparators. > > + * @nrseqstate: The number of sequencer states that are implemented. > > + * @nr_event: Indicates how many events the trace unit support. > > + * @nr_resource:The number of resource selection pairs available for tracing. > > + * @nr_ss_cmp: Number of single-shot comparator controls that are available. > > + * @trcid_size: Indicates the trace ID width. > > + * @ts_size: Global timestamp size field. > > + * @ctxid_size: Size of the context ID field to consider. > > + * @vmid_size: Size of the VM ID comparator to consider. > > + * @ccsize: Indicates the size of the cycle counter in bits. > > + * @ccitmin: minimum value that can be programmed in > > + * @s_ex_level: In secure state, indicates whether instruction tracing is > > + * supported for the corresponding Exception level. > > + * @ns_ex_level:In non-secure state, indicates whether instruction tracing is > > + * supported for the corresponding Exception level. > > + * @q_support: Q element support characteristics. > > + * @os_lock_model: OSLock model. > > + * @instrp0: Tracing of load and store instructions > > + * as P0 elements is supported. > > + * @q_filt: Q element filtering support, if Q elements are supported. > > + * @trcbb: Indicates if the trace unit supports branch broadcast tracing. > > + * @trccond: If the trace unit supports conditional > > + * instruction tracing. > > + * @retstack: Indicates if the implementation supports a return stack. > > + * @trccci: Indicates if the trace unit supports cycle counting > > + * for instruction. > > + * @trc_error: Whether a trace unit can trace a system > > + * error exception. > > + * @syncpr: Indicates if an implementation has a fixed > > + * synchronization period. > > + * @stallctl: If functionality that prevents trace unit buffer overflows > > + * is available. > > + * @sysstall: Does the system support stall control of the PE? > > + * @nooverflow: Indicate if overflow prevention is supported. > > + * @atbtrig: If the implementation can support ATB triggers > > + * @lpoverride: If the implementation can support low-power state over. > > + * @skip_power_up: Indicates if an implementation can skip powering up > > + * the trace unit. > > + */ > > +struct etmv4_caps { > > + u8 nr_pe; > > + u8 nr_pe_cmp; > > + u8 nr_addr_cmp; > > + u8 nr_cntr; > > + u8 nr_ext_inp; > > + u8 numcidc; > > + u8 numextinsel; > > missed kernel_doc. > > Thanks, > Jie Thanks. I'll add comment for numextinsel. -- Sincerely, Yeoreum Yun