From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD6AC31F9AF for ; Mon, 13 Apr 2026 07:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776063892; cv=none; b=MYsSmh8Z1C4c6SFCpF5dGapdHK2x1WCLS9+otBpuECxzdLReulCvUlit1m6Xh6qR8/jy7UwP/MwvnNI/LB4J4tWd6UY86Zwezw/wUi56HsforaXa4z0EsmnLsOXSXEX+nhiK5SIxiM9kqF7STr52P6+02hfd+uxNx2NVjIhfYfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776063892; c=relaxed/simple; bh=6DPXTQznbeRTX7f0ifOTeZ3YoaZSkHdQlEP01PRpIFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DPCbJ2f3W/EIauHurcMnVuG9eVmxwGcD6U+1yNsVeB+J6PE3m5GM9eYXaBIC04hifiU2j24cqsZxa79WSyBA+MlehYyNbWICs10zZ6iMZKKiJymA8TQztX1p5wnkI7bhKe2Y2qXATlYBCCX0/Xs4hdTbdbZYaaJqgMCikrRTAWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WzAEaUYk; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WzAEaUYk" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43d7213b6ebso663554f8f.3 for ; Mon, 13 Apr 2026 00:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776063890; x=1776668690; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oRBxi9VXhNJNAcKSM1KuAwC9XmMF3xEafmK85DMI9C0=; b=WzAEaUYkhCVMNyOvRM2+wS79CspaHupci5bsoJ21YC1IhA3IyHb8dUlU8/ZpKs+7TQ 5L3zM1xZbFf17V1gRv/cGSi6A9RBab1dMrNvy98FL139aynkBxrMWH7DQ25l6pTAyYSv ODeodtHOH13gZjnaWioig45NTvvWlbWHNCCID3dvnjb1TeYU52VsAKMp8J4rRLlN2y8w U0qBVlV8Cegegr2JNApziTfyAlywT7XY9/NZeTPmLHkM2ZpIZKYIrvtO7u9mT419jf9J U9+Crz1zteM8sty2zaKzQPt9kWMYyh7ZPn4b6CYpvSgLk+1cstg4DB2DbfngjM7B6SYb E8Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776063890; x=1776668690; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oRBxi9VXhNJNAcKSM1KuAwC9XmMF3xEafmK85DMI9C0=; b=I4NZtGuGddZQ4SZRnQEE4A9RobNW+91WkF2rAaHpPflFm+oWe09RFIwODfGWlROwzF lk5qzDACD11wkgfYhzdbjI2klK80O85R52ZR9VWG15obF5Mv91xXwtuM9DEz6Qefue9y Rr3h9rZBgS1hqlZS8zLjSP1YhhD+DJ1XMoQRC+cDzOMTEcZbw/laEmO1PgzI9u/Y8X4X n60JDjIzqlaJUoC8KgE31nytfyyydSj5ShMT/joeescymLqqG9H/4S8n3sUKG2lACYrB EijmBA4Sq/2VTuckdZ5cRCyfUB+8jO0QSvwJ/A1iImXvgTTHJf1ZXwdQ+7r9jLKITjCY LiCA== X-Forwarded-Encrypted: i=1; AFNElJ8LJSnAN95E70axknnwb7xRiAkQ439R5oqZfSIWZh7v3e1ynpRVMg5T4nVfG2TKgqPbHTN4Xi0J30x0U1A=@vger.kernel.org X-Gm-Message-State: AOJu0YwEOMrkXPhLO1B1uXr9LbTelPkwijWfyWze+Vh3oQIWlSj4zwsZ yp9aoPHvfI7/cHL3HYwivEswWIEq+Vmm1qnf0vA3J8AY1rR0O25Lom0z X-Gm-Gg: AeBDietIwjfHTtRnfBqqAWTPmdH81rEF4b3UUQF5jXOg8vhQEfaD3oGvz1vX7FBPmAu Thy5OQYBGq9zGw6hIHerNiMIIy64XltIu+7GlWvHCvLJnBb79yQqpEZJg35T69kMYGabMV5GVhL vC6+hJlg3j2IQGEEaW2IOK1u3EFmXzO4BPPVHshosgoxfIgrVOwTiFMzFvk0NFDCcL2Ibl9X++C 28LKPWXMV3RaEfgtQIQyS0xKoat2uSKn5EmtgUesF4yOeenwevZFb3SvK4H9uVOgwR2b7PKBrhI EA4T6/xzyNK0H8qlPO54EYTIODCPMK9KockoWu9QouK+sL9v5UAPiSQHbdmnRuLyxWZ+0pqcvs7 oVuD7Xy68jGr5AFWsMdEzOdJtkXbkAQY6hHiJiD7eodj9h/4VOSGmDEp/aAVIOxyQySRE8vzs6H zAdcqsW+vzcdeuGYD6GZ4= X-Received: by 2002:a05:6000:400a:b0:43c:f4df:9245 with SMTP id ffacd0b85a97d-43d642cbb8bmr18191781f8f.47.1776063889770; Mon, 13 Apr 2026 00:04:49 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d7794cce5sm7509912f8f.9.2026.04.13.00.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 00:04:49 -0700 (PDT) Date: Mon, 13 Apr 2026 10:04:46 +0300 From: Dan Carpenter To: Hungyu Lin Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] greybus: audio: extract topology size retrieval into a helper Message-ID: References: <20260411182055.24413-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260411182055.24413-1-dennylin0707@gmail.com> On Sat, Apr 11, 2026 at 06:20:55PM +0000, Hungyu Lin wrote: > The topology retrieval code currently mixes the size query with > allocation and data fetch in a single function. > > Extract the size query into a helper to make the control flow clearer. > > No functional change. > > Signed-off-by: Hungyu Lin > --- > drivers/staging/greybus/audio_gb.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) I don't see how this is a cleanup at all... If you were the maintainer of the code, then you could do whatever you want, but this is your first kernel patch. regards, dan carpenter