From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: <chris@printf.net>, <michal.simek@xilinx.com>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection
Date: Tue, 4 Mar 2014 13:00:55 -0800 [thread overview]
Message-ID: <ae0f71ac-c5f7-4af7-a9ba-c019cec19ebf@AM1EHSMHS017.ehs.local> (raw)
In-Reply-To: <53163247.8000904@gmail.com>
On Tue, 2014-03-04 at 10:06PM +0200, Eli Billauer wrote:
> Hello Sören,
>
> wp-inverted solves the practical problem indeed, and fools the
> driver into thinking that the card has an inverted write protection
> sensor, and the logic zero that it finds in the hardware register
> means that the card isn't write protected.
>
> I'm insisting on this patch, because I think that the device tree
> should describe the hardware as it is, and not fool the driver into
> behaving the way we want it to. These tricks always bite back later
> on.
Well, why is broken-wp more accurate than wp-inverted? Strictly
speaking the WP is there and working, it's just tied off to some value
you want to have interpreted the other way.
Anyway, seems like this is solvable with wp-inverted and whether the
additional quirk is needed I leave to others do decide.
Sören
next prev parent reply other threads:[~2014-03-04 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 11:20 Eli Billauer
2014-03-04 19:26 ` Sören Brinkmann
2014-03-04 20:06 ` Eli Billauer
2014-03-04 21:00 ` Sören Brinkmann [this message]
2014-03-06 13:31 ` Mike Looijmans
2014-03-06 16:42 ` Sören Brinkmann
2014-03-20 12:26 ` Michal Simek
2014-03-20 12:39 ` Eli Billauer
2014-03-20 13:04 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae0f71ac-c5f7-4af7-a9ba-c019cec19ebf@AM1EHSMHS017.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=eli.billauer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®