From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49246.qiye.163.com (mail-m49246.qiye.163.com [45.254.49.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C3EC2FF166; Tue, 26 Aug 2025 09:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756200870; cv=none; b=OrudDkMSImsIuyrSUm/E7QXOo4+hOkOS/sKjXFKoGEmN9Tn/YDSidxvmVIsY1+rasb4/7vmDqs4YUXNxR29R21Y4i1RM7JpiO5sOH2pVyLPB+wDel0X5PG6tpvL+OvzDw4eLO1LOwhTRpi81ASnVtKjLpcHF1T9PY63b92bWP9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756200870; c=relaxed/simple; bh=mFV+XxuFxFv8isEZatVz54NqgXb1Jr5GkM0Fs8jON+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UO65jqbvMRurupyRM8lC29u/aLFVF8SayzbBc/Bzp1vS9YBRb7fb1LgvTi4FGQhocGrKvzdZRiawPaOBzMmEPpFV+4gcQ6mhV1EX0h+AF1VeRrQ8qsy2oVhs8cZkF3XJkBMDid4V6Bix/JY+1B1OaKBs2QeAUXg6utp0XUr4WJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=d+nvem5r; arc=none smtp.client-ip=45.254.49.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="d+nvem5r" Received: from [172.16.12.153] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 20a66879b; Tue, 26 Aug 2025 17:29:06 +0800 (GMT+08:00) Message-ID: Date: Tue, 26 Aug 2025 17:29:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: ethernet: stmmac: dwmac-rk: Make the clk_phy could be used for external phy To: "Russell King (Oracle)" Cc: Marek Szyprowski , Chaoyi Chen , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Jonas Karlman , David Wu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20250815023515.114-1-kernel@airkyi.com> <809848c9-2ffa-4743-adda-b8b714b404de@samsung.com> <8240a3cc-aade-40d8-b2f4-09681f76be68@rock-chips.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a98e5b5b15b03abkunm7ebc238e12acdf2 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkpJHVZIGUJDTEtPTR9JH0tWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=d+nvem5rq+OdX5QANolTVxd6PoZAEDv1TqtFvJ3xCapUp0mrt5rvGanWBQuRmxpya0wc2AL+cDxtbWGKDw1ZAleQS4w0XgNjQvhsDvLOodrUm5jzmofqfL0aOAV645iDH7xQIjlMx/bZ0IEstSGFCxriCCPC15is03iEJTesAgg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=lBlDCclLQ1+AiQeVLpAB/kctkShHB5e19AZ8+JDxJP0=; h=date:mime-version:subject:message-id:from; On 8/26/2025 5:25 PM, Russell King (Oracle) wrote: > On Tue, Aug 26, 2025 at 04:08:40PM +0800, Chaoyi Chen wrote: >> Hi Russell, >> >> On 8/25/2025 9:37 PM, Russell King (Oracle) wrote: >>> On Mon, Aug 25, 2025 at 12:53:37PM +0200, Marek Szyprowski wrote: >>>> On 25.08.2025 11:57, Chaoyi Chen wrote: >>>>> On 8/25/2025 3:23 PM, Marek Szyprowski wrote: >>>>>> On 15.08.2025 04:35, Chaoyi Chen wrote: >>>>>>> From: Chaoyi Chen >>>>>>> >>>>>>> For external phy, clk_phy should be optional, and some external phy >>>>>>> need the clock input from clk_phy. This patch adds support for setting >>>>>>> clk_phy for external phy. >>>>>>> >>>>>>> Signed-off-by: David Wu >>>>>>> Signed-off-by: Chaoyi Chen >>>>>>> --- >>>>>>> >>>>>>> Changes in v3: >>>>>>> - Link to V2: >>>>>>> https://lore.kernel.org/netdev/20250812012127.197-1-kernel@airkyi.com/ >>>>>>> - Rebase to net-next/main >>>>>>> >>>>>>> Changes in v2: >>>>>>> - Link to V1: >>>>>>> https://lore.kernel.org/netdev/20250806011405.115-1-kernel@airkyi.com/ >>>>>>> - Remove get clock frequency from DT prop >>>>>>> >>>>>>>    drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 11 +++++++---- >>>>>>>    1 file changed, 7 insertions(+), 4 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>>>>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>>>>> index ac8288301994..5d921e62c2f5 100644 >>>>>>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>>>>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>>>>> @@ -1412,12 +1412,15 @@ static int rk_gmac_clk_init(struct >>>>>>> plat_stmmacenet_data *plat) >>>>>>>            clk_set_rate(plat->stmmac_clk, 50000000); >>>>>>>        } >>>>>>>    -    if (plat->phy_node && bsp_priv->integrated_phy) { >>>>>>> +    if (plat->phy_node) { >>>>>>>            bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0); >>>>>>>            ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); >>>>>>> -        if (ret) >>>>>>> -            return dev_err_probe(dev, ret, "Cannot get PHY clock\n"); >>>>>>> -        clk_set_rate(bsp_priv->clk_phy, 50000000); >>>>>>> +        /* If it is not integrated_phy, clk_phy is optional */ >>>>>>> +        if (bsp_priv->integrated_phy) { >>>>>>> +            if (ret) >>>>>>> +                return dev_err_probe(dev, ret, "Cannot get PHY >>>>>>> clock\n"); >>>>>>> +            clk_set_rate(bsp_priv->clk_phy, 50000000); >>>>>>> +        } >>>>> I think  we should set bsp_priv->clk_phy to NULL here if we failed to >>>>> get the clock. >>>>> >>>>> Could you try this on your board? Thank you. >>>> Right, the following change also fixes this issue: >>>> >>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>> index 9fc41207cc45..2d19d48be01f 100644 >>>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>>> @@ -1415,6 +1415,8 @@ static int rk_gmac_clk_init(struct >>>> plat_stmmacenet_data *plat) >>>>         if (plat->phy_node) { >>>>                 bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0); >>>>                 ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); >>>> +               if (ret) >>>> +                       bsp_priv->clk_phy = NULL; >>> Or just: >>> >>> clk = of_clk_get(plat->phy_node, 0); >>> if (clk == ERR_PTR(-EPROBE_DEFER)) >> Do we actually need this? Maybe other devm_clk_get() before it would fail in advance. > Is it the same clock as devm_clk_get()? If it is, what's the point of > getting it a second time. If it isn't, then it could be a different > clock which may be yet to probe. It's not the same clock, but it should be use the same clock controller driver, which is the CRU on the Rockchip platform.