From: Krzysztof Kozlowski <krzk@kernel.org>
To: yuanjiey <yuanjie.yang@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com,
quic_yuanjiey@quicinc.com, kernel@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file
Date: Wed, 23 Jul 2025 10:59:38 +0200 [thread overview]
Message-ID: <ae1310d3-12e1-4856-8f34-1c51bdfbf44a@kernel.org> (raw)
In-Reply-To: <aICjeK+gC1yxPb9I@yuanjiey.ap.qualcomm.com>
On 23/07/2025 10:55, yuanjiey wrote:
> On Wed, Jul 23, 2025 at 10:49:10AM +0200, Krzysztof Kozlowski wrote:
>> On 23/07/2025 10:43, yuanjie yang wrote:
>>> From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
>>>
>>> Remove redundant gpio header file in QCS615 RIDE DTS.
>>
>> I do not see it redundant at all. Just look at the file - it is used.
> qcs615-ride.dts: file
>
> line:
> 7:#include <dt-bindings/gpio/gpio.h>
> 8:#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> 9:#include <dt-bindings/gpio/gpio.h>
>
> I see line 7 and line 9 include the same <dt-bindings/gpio/gpio.h>,
> I think we can remove one header file.
>
So say that it is there twice...
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-23 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:43 yuanjie yang
2025-07-23 8:49 ` Krzysztof Kozlowski
2025-07-23 8:55 ` yuanjiey
2025-07-23 8:59 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae1310d3-12e1-4856-8f34-1c51bdfbf44a@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=robh@kernel.org \
--cc=yuanjie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®