From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9129C04ABB for ; Wed, 12 Sep 2018 03:16:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8404820882 for ; Wed, 12 Sep 2018 03:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8404820882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727051AbeILISW (ORCPT ); Wed, 12 Sep 2018 04:18:22 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:35922 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbeILISV (ORCPT ); Wed, 12 Sep 2018 04:18:21 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8C3EtSR113898 for ; Tue, 11 Sep 2018 23:15:58 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2meqxvwdtj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 11 Sep 2018 23:15:57 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Sep 2018 04:15:55 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 12 Sep 2018 04:15:51 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8C3Fnha58261738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Sep 2018 03:15:49 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BFDCD5204F; Wed, 12 Sep 2018 06:15:38 +0100 (BST) Received: from [9.124.35.146] (unknown [9.124.35.146]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id C1D2E52050; Wed, 12 Sep 2018 06:15:36 +0100 (BST) Subject: Re: [PATCH] perf test: Add watchpoint test To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: alexander.shishkin@linux.intel.com, namhyung@kernel.org, tmricht@linux.ibm.com, sandipan@linux.ibm.com, brueckner@linux.ibm.com, kim.phillips@arm.com, kstewart@linuxfoundation.org, tglx@linutronix.de, naveen.n.rao@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Ravi Bangoria References: <20180910095811.22892-1-ravi.bangoria@linux.ibm.com> <20180910103154.GD15548@krava> <20180910134754.GC5147@kernel.org> <20180910141830.GI5147@kernel.org> From: Ravi Bangoria Date: Wed, 12 Sep 2018 08:45:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180910141830.GI5147@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18091203-0008-0000-0000-0000026FFAC9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18091203-0009-0000-0000-000021D834CB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-12_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809120033 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > While testing, I got curious, as a 'perf test' user, why one of the > tests had the "Skip" result: > > [root@seventh ~]# perf test watchpoint > 22: Watchpoint : > 22.1: Read Only Watchpoint : Skip > 22.2: Write Only Watchpoint : Ok > 22.3: Read / Write Watchpoint : Ok > 22.4: Modify Watchpoint : Ok > [root@seventh ~]# > > I tried with 'perf test -v watchpoint' but that didn't help, perhaps you > could add some message after the "Skip" telling why it skipped that > test? I.e. hardware doesn't have that capability, kernel driver not yet > supporting that, something else? Sure will add a message: pr_debug("Hardware does not support read only watchpoints."); Ravi