From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbdKVQYl (ORCPT ); Wed, 22 Nov 2017 11:24:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54868 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdKVQYi (ORCPT ); Wed, 22 Nov 2017 11:24:38 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9226B607E8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 12/30] Drivers: ide: deprecate pci_get_bus_and_slot() To: Greg KH Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "David S. Miller" , "open list:IDE SUBSYSTEM" , open list References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-13-git-send-email-okaya@codeaurora.org> <20171122075302.GB26583@kroah.com> From: Sinan Kaya Message-ID: Date: Wed, 22 Nov 2017 11:24:35 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171122075302.GB26583@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/2017 2:53 AM, Greg KH wrote: > On Wed, Nov 22, 2017 at 12:30:57AM -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >> where a PCI device is present. This restricts the device drivers to be >> reused for other domain numbers. >> >> Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't >> extract the domain number. Other places, use the actual domain number from >> the device. > > While this is a great generic text, you might want to make it a bit more > custom to each specific patch. For example, you don't use a domain of 0 > in this one, so the text is a bit wrong and confusing if you look at it > stand-alone. > > I like the series and the idea, just fix up this text in some of the > patches and you should be fine. OK. Will do on the next version. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.