From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77951C43217 for ; Thu, 10 Nov 2022 12:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbiKJMIC (ORCPT ); Thu, 10 Nov 2022 07:08:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbiKJMIA (ORCPT ); Thu, 10 Nov 2022 07:08:00 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D16DC716CE for ; Thu, 10 Nov 2022 04:07:58 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b3so2834319lfv.2 for ; Thu, 10 Nov 2022 04:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=wTZeoUecrKlOpac1f+l+tkMwOwFXx8RW3xq7DuV+DMM=; b=OtYSVx109vXNxZR6GezrRVsY0MmmZtoobU4DmFkpd1Ns/JbNXoL923ZWlTehmQ/Gpf GTvhutOnU9np1mi0Nbe6XMkBt4IVwB6F4GhrY3X8Tj6u8SlIjXLdS0KlybmYbPqs7sMs rHLruuC6Gff6OvM0r+Bziqp/0OzwnEcnX52me9rqCd8FGDxtYxKZU7GKf56ef3EVOJaf CrFEd8pOrgmPBuyu397MsrOUiNNfjQTIQ7OViY3RMaIKH3WWer9XbbI15Y4fdXNOM1Bt AXOvD07WywGP+SD6TwhX1wAh1G9/fQHDTsIo7bYvmMgaNMh6iBE0iAbqwqvcu4upMys3 rbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wTZeoUecrKlOpac1f+l+tkMwOwFXx8RW3xq7DuV+DMM=; b=NSMO6Z4hVN49KmRy7X1F7dadA14QyTVBvuFLtDhNv9SzSTDGyatiX/mz7sPgyfrZcc Ld94G/ElT4cNk+IR6bmZYXc/GaPawm1uR8foKDYXdvRzLaim1W2ElQJ5IY4+EWWynkqU bi5MZV6TQgZm8QYgt4IZlCbULrZ0rp5R0h6kM6Dxq6x+wkq0Hkj8+ejlqVXcBbbNo3yy wCSD2Wpe18Ryj+/bcStOq+Tka05pg1q6U3XMrZim0/UbjQYolhXjeTCSjyR4GKMEJhcF Ev16oUojQkiAwKVP5jl4SGDwq8GTMONmtAoh5SHVCP4p7gc9t1r+XVUZhg+y8w0otmSm 7Q1A== X-Gm-Message-State: ACrzQf3D61UMctd5xt58yLKNiNizK6Tmfhz7zU4b6OEW3cQQPLRd0pfG 3agJ6FVZkaVlCHGqW0v55uZEng== X-Google-Smtp-Source: AMsMyM5Fy2ozvGSmP1vbjydCPG2UhS0gqPhZr248VdsYUlWeNBm//9YGxeKM10fZPGnjA3WXzapXsQ== X-Received: by 2002:a19:790d:0:b0:4a2:3d87:8d14 with SMTP id u13-20020a19790d000000b004a23d878d14mr1548113lfc.161.1668082077160; Thu, 10 Nov 2022 04:07:57 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id m4-20020a056512114400b004979db5aa5bsm2727460lfg.223.2022.11.10.04.07.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 04:07:56 -0800 (PST) Message-ID: Date: Thu, 10 Nov 2022 13:07:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 03/10] arm64: dts: qcom: Add a device tree for PMK8350 on SID6 To: Dmitry Baryshkov , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org, patches@linaro.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221109111236.46003-1-konrad.dybcio@linaro.org> <20221109111236.46003-4-konrad.dybcio@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2022 10:12, Dmitry Baryshkov wrote: > On Wed, 9 Nov 2022 at 14:12, Konrad Dybcio wrote: >> >> PMK8350 is shipped on SID6 with some SoCs, for example with SM6375. >> Add a DT with the SID changed to allow it to work. >> >> Unfortunately, the entire DT needs to be copied even if the diff is >> very little, as the node names are not unique. Including pm6125 and >> pmk8350 together for example, would make pmk8350 overwrite the pm6125 >> node, as both are defined as 'pmic@0'. >> >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/pmk8350_sid6.dtsi | 73 ++++++++++++++++++++++ >> 1 file changed, 73 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/pmk8350_sid6.dtsi > > Just to throw my 2c. If I was doing this myself, I'd allow pmk8350 to > receive external SID using the cpp #define (And to default to 0 if one > didn't use it). Hmm.. that's probably the least duplicative approach, but I'm not sure I want to see #ifdefs in DTs.. Konrad > > > >