From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E04B175A98 for ; Sun, 26 Apr 2026 01:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777166044; cv=none; b=QCfcYJQ1xomPvU2TGMWwCgKEVa9nCKWDmEzWmSci5d4EwJcQi5btXQmONoyC6R5dLJzjS719rv2FzgaFt579D6KPccrhcS2MNdozXm6b3PWf0lJb3ek4v7geltD1+TRhmrvIRNGy0sq4sjacxzzrRcO5ZlQT1P4AWq+CgOkZAlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777166044; c=relaxed/simple; bh=LMEYiuTHUxBVUNlCSiGyL7X3QyORbXgi9HOV3k15oW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VQbIcys+2IvBRI1VgpmhTzcai2fTd7WEfNkd5Y+H0wqL/0C7Ts5C//asqZ8M+SqcdShaWQO4KTojh2/vu0yXYuq8tXUXbSSlUWDRUST1eKx4yjUfgw65hr1cf5S/3Fzn+q+XpVWK3UQ5+Oj57BsOkz7GYqdlwWVA6AIEABxkgoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CLVuZV84; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CLVuZV84" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ab077e3f32so38847875ad.3 for ; Sat, 25 Apr 2026 18:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777166043; x=1777770843; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jdHw7CqZVYULzvQHcmJctGPHRqkIKbc4D3SQwtavlTk=; b=CLVuZV8484KiLZ5MEC6R7vu16w1Z743mL3CFm9/UJdY5U1Bo9B/JDBShrj9q5DeBh6 fMJsG9oQq5SRp+tW0poLmVEWNLWLaLtFR1F8XsiYEfFigwDzXTx0s40/JER6PemyUEwM G9EG7R6OuvQ1eE1qZZGMExsxC8H5tQWhu22jFItVCHyxyvzfc3OTA0+288KCfebvzigl GjnbP8QlL15hsFXQluHM2Cru6Ep/O4oi8y17xgzB3iPF3Jpl1KGbkYhSM3rPLHT4+M2j dWc5e7hpKvMGkzjJwSj70Kvf3mmEaDcaAE/tFQej51du3NV58TEHojfYunj7Qptlbzs9 BSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777166043; x=1777770843; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jdHw7CqZVYULzvQHcmJctGPHRqkIKbc4D3SQwtavlTk=; b=NmrG4Ra82Urnni8zg5X624YY9qSeTRWT+/lBqJF+GsrrxgQw+LAPkuYlmCdZ+RP7w0 VyNYgiSgg0WjdH8o7bLjLkRdAJQaQlMFd7eG9v0An5AvrqOCW8/l3hm0bkulvPiplTim TdzMoekA3HG6g4H/yUvlxpaNuTHr8zKQV9AqQ9mEq+d/JegsFsQF9+5plBl7y8X+5kPL 3Y0KU4I11d2z+HgBaW72AYYlpN28dJh+MVcMbaJ98sesbPyjAtmEreQXI7/6mdFGQCid 7Y/i+wmBc28RFHPafQlPD3DuywaCXa6iRVnT50FQO/NVjU1qP9KpfVUfVepJ36Na2maC As2g== X-Forwarded-Encrypted: i=1; AFNElJ/wjAradIWzvm8DaScp4bcr63EzQvIbLFZ1X0YMIXhrEbyTIr7nYQv0UWqwFqVWF9/meLf7b53EZN84+NE=@vger.kernel.org X-Gm-Message-State: AOJu0Yya/5svN/24rPpjvFq9vD+4wEXUKrC4K7Fs9z4zUI0LJKPsqzoK LZcICSV6mYzLco3pHiTqi4+e4WcLgbR9CKiC7g5GrNJiXIq3Igy5UfJd X-Gm-Gg: AeBDievQQYNY+a0cS0oKRG6p0v93vQpDTi38wl8KejlvgpL7fvzQvAR2tB/5ZYA5ZUQ 46jVAYF6f5uYlMK8448xCo2fDzUwT2jjqoKBgx5O2XTL0s+xVyJUj2QcBxZoqQdjZJgRG2mkjJh izDqDuZ+HM4svEk4Zx5RC/bhR5IMHgeq1IgOsZxG6jSDFGLOaiBtt7x5QuByIVgVebgcFLJpohX cBWlzW0D5+JxNqFwJA8CK1fE3gSEFKF/EzBYHCFvL3kzwB5i/lyVCAgk70BfgtWsOt8N8I4UykT /v7rCxTkwVzkQ5lgxMsPjN7HVu47Y+iETvqDvG83AlO58sOfPyK6JX/0I7GOTUAQt5ElbFTb4OF eCamQeMqj3jDkTbRlpgBD1x/ahbUQJbBpnFsnudDgvWEUZwxkuXeSK6H708+IDSoF/hT82DCcC1 /X2eF+znIYFq/ydfuYBei+PL80TDFgeGqUmA== X-Received: by 2002:a17:903:907:b0:2b2:42b1:adac with SMTP id d9443c01a7336-2b5f9e7707fmr401674315ad.3.1777166042579; Sat, 25 Apr 2026 18:14:02 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa494e1sm263402365ad.35.2026.04.25.18.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 18:14:02 -0700 (PDT) Date: Sun, 26 Apr 2026 09:13:58 +0800 From: Inochi Amaoto To: "Gabriel L. Somlo" , Inochi Amaoto Cc: Ulf Hansson , Karol Gugala , Mateusz Holenko , Joel Stanley , Kamil Rakoczy , Paul Mackerras , Andy Shevchenko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v2] mmc: litex_mmc: Set mandatory idle clocks before CMD0 Message-ID: References: <20260424013615.470325-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 24, 2026 at 11:12:21AM -0400, Gabriel L. Somlo wrote: > Hi, > > Thanks for the patch! > > On Fri, Apr 24, 2026 at 09:36:14AM +0800, Inochi Amaoto wrote: > > The litex_mmc driver assumes the card is already probed in the BIOS > > and skip the phy initialization. This will cause the command fail > > like the following when the old card is unplugged and then insert > > a new card: > > > > [ 62.923593] litex-mmc f0004000.mmc: Command (cmd 8) error, status -110 > > [ 62.949717] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 62.976606] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.002516] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.028442] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > > > Add required clock settings and initialization for the CMD 0, so it can > > probe the new card. > > > > Fixes: 92e099104729 ("mmc: Add driver for LiteX's LiteSDCard interface") > > Signed-off-by: Inochi Amaoto > > --- > > Change from v1: > > - https://lore.kernel.org/linux-mmc/20260421025052.755471-1-inochiama@gmail.com/ > > 1. use fsleep to replace udelay > > --- > > drivers/mmc/host/litex_mmc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c > > index d2f19c2dc673..ac0b47604c02 100644 > > --- a/drivers/mmc/host/litex_mmc.c > > +++ b/drivers/mmc/host/litex_mmc.c > > @@ -68,6 +68,9 @@ > > #define SD_SLEEP_US 5 > > #define SD_TIMEOUT_US 20000 > > > > +#define SD_INIT_DELAY_US 1000 > > +#define SD_INIT_CLK_HZ 400000 > > + > > #define SDIRQ_CARD_DETECT 1 > > #define SDIRQ_SD_TO_MEM_DONE 2 > > #define SDIRQ_MEM_TO_SD_DONE 4 > > @@ -99,6 +102,8 @@ struct litex_mmc_host { > > bool app_cmd; > > }; > > > > +static void litex_mmc_setclk(struct litex_mmc_host *host, unsigned int freq); > > + > > Instead of the forward reference, can you simply move the entire > `litex_mmc_setclk` function definition to this location in the file? > (i.e., add a separate, "cosmetic" patch simply cut'n'pasting the > function body from one place to another, with a commit blurb stating > that it's in preparation for the idle-clock fix, and that it contains > only cosmetic, no functional changes)? > > The idle-clock fix patch can then contain nothing but the > "#define SD_INIT_*" lines and the hunk below: > Thanks, it is fine for me. I will send a new version for this. Regards, Inochi > > static int litex_mmc_sdcard_wait_done(void __iomem *reg, struct device *dev) > > { > > u8 evt; > > @@ -128,6 +133,12 @@ static int litex_mmc_send_cmd(struct litex_mmc_host *host, > > int ret; > > u8 evt; > > > > + if (cmd == MMC_GO_IDLE_STATE) { > > + litex_mmc_setclk(host, SD_INIT_CLK_HZ); > > + litex_write8(host->sdphy + LITEX_PHY_INITIALIZE, 1); > > + fsleep(SD_INIT_DELAY_US); > > + } > > + > > litex_write32(host->sdcore + LITEX_CORE_CMDARG, arg); > > litex_write32(host->sdcore + LITEX_CORE_CMDCMD, > > cmd << 8 | transfer << 5 | response_len); > > Thanks much, > --Gabriel