From: Robin Murphy <robin.murphy@arm.com>
To: Auger Eric <eric.auger@redhat.com>, eric.auger.pro@gmail.com
Cc: Joerg Roedel <joro@8bytes.org>,
christoffer.dall@linaro.org, marc.zyngier@arm.com,
alex.williamson@redhat.com, will.deacon@arm.com,
tglx@linutronix.de, jason@lakedaemon.net,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
drjones@redhat.com, linux-kernel@vger.kernel.org,
pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org,
punit.agrawal@arm.com, diana.craciun@nxp.com,
gpkulkarni@gmail.com, shankerd@codeaurora.org,
bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com
Subject: Re: [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies
Date: Fri, 6 Jan 2017 12:12:20 +0000 [thread overview]
Message-ID: <ae222579-6939-b89a-80c2-9ee8f147299e@arm.com> (raw)
In-Reply-To: <b058a7f9-84bf-1d5c-1c24-24da251cc964@redhat.com>
On 06/01/17 11:46, Auger Eric wrote:
>
>
> On 06/01/2017 11:59, Joerg Roedel wrote:
>> On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote:
>>> struct iommu_dma_cookie {
>>> - struct iova_domain iovad;
>>> - struct list_head msi_page_list;
>>> - spinlock_t msi_lock;
>>> + union {
>>> + struct iova_domain iovad;
>>> + dma_addr_t msi_iova;
>>> + };
>>> + struct list_head msi_page_list;
>>> + spinlock_t msi_lock;
>>> + enum iommu_dma_cookie_type type;
>>
>> Please move the type to the beginning of the struct and add a comment
>> how the type relates to the union.
>
> Sure
>
> Thank you for the review.
FWIW I already had a cleaned up version of this patch, I just hadn't
mentioned it. I've pushed out an update with that change added too[1].
Robin.
[1]:http://linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/misc
>
> Best regards
>
> Eric
>>
>>
>>
>> Joerg
>>
next prev parent reply other threads:[~2017-01-06 12:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 19:04 [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-06 10:59 ` Joerg Roedel
2017-01-06 11:46 ` Auger Eric
2017-01-06 12:12 ` Robin Murphy [this message]
2017-01-06 13:05 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 02/18] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 03/18] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-05 19:04 ` [PATCH v6 04/18] iommu: iommu_alloc_resv_region Eric Auger
2017-01-05 19:04 ` [PATCH v6 05/18] iommu: Only map direct mapped regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 06/18] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 07/18] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-06 11:00 ` Joerg Roedel
2017-01-06 11:46 ` Auger Eric
2017-01-06 12:48 ` Joerg Roedel
2017-01-06 13:04 ` Auger Eric
2017-01-06 17:18 ` Auger Eric
2017-01-08 16:26 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 08/18] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-06 11:01 ` Joerg Roedel
2017-01-06 11:45 ` Auger Eric
2017-01-06 12:46 ` Joerg Roedel
2017-01-06 13:03 ` Auger Eric
2017-01-05 19:04 ` [PATCH v6 09/18] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-05 19:04 ` [PATCH v6 10/18] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-05 19:04 ` [PATCH v6 11/18] iommu/arm-smmu-v3: " Eric Auger
2017-01-05 19:04 ` [PATCH v6 12/18] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-05 19:04 ` [PATCH v6 13/18] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-05 19:04 ` [PATCH v6 14/18] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-05 19:04 ` [PATCH v6 15/18] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-05 19:04 ` [PATCH v6 16/18] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-05 19:04 ` [PATCH v6 17/18] vfio/type1: Check MSI remapping at irq domain level Eric Auger
2017-01-06 8:50 ` Bharat Bhushan
2017-01-06 9:08 ` Auger Eric
2017-01-06 9:20 ` Marc Zyngier
2017-01-06 9:31 ` Bharat Bhushan
2017-01-05 19:04 ` [PATCH v6 18/18] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-06 11:02 ` [PATCH v6 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae222579-6939-b89a-80c2-9ee8f147299e@arm.com \
--to=robin.murphy@arm.com \
--cc=alex.williamson@redhat.com \
--cc=bharat.bhushan@nxp.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@nxp.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=geethasowjanya.akula@gmail.com \
--cc=gpkulkarni@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pranav.sawargaonkar@gmail.com \
--cc=punit.agrawal@arm.com \
--cc=shankerd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®