From: Kyle Switch <kyle.switch@motor-comm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
jie.han@motor-comm.com
Subject: Re: [PATCH net-next v4] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
Date: Tue, 21 Jul 2026 19:47:42 +0800 [thread overview]
Message-ID: <ae2384a7-1fb5-4a58-87f2-ee81ed5e6d47@motor-comm.com> (raw)
In-Reply-To: <cafd8d43-7f76-44d8-a579-670d911f9b91@lunn.ch>
On 7/20/26 21:48, Andrew Lunn wrote:
> On Mon, Jul 20, 2026 at 05:11:33PM +0800, Kyle Switch wrote:
>> Add a driver for motorcomm yt8824 quad 2.5G ethernet phy, supports
>> 2.5G/1000M/100M/10M speed.
>
> So this is better, however still not correct.
>
>> - /* Enable WOL feature */
>> - mask = YTPHY_WCR_PULSE_WIDTH_MASK | YTPHY_WCR_INTR_SEL;
>> - val = YTPHY_WCR_ENABLE | YTPHY_WCR_INTR_SEL;
>> - val |= YTPHY_WCR_TYPE_PULSE | YTPHY_WCR_PULSE_WIDTH_672MS;
>> - ret = ytphy_modify_ext(phydev, YTPHY_WOL_CONFIG_REG, mask, val);
>> + /* Enable WOL feature */
>> + mask = YTPHY_WCR_PULSE_WIDTH_MASK | YTPHY_WCR_INTR_SEL;
>> + val = YTPHY_WCR_ENABLE | YTPHY_WCR_INTR_SEL;
>> + val |= YTPHY_WCR_TYPE_PULSE | YTPHY_WCR_PULSE_WIDTH_672MS;
>> + ret = ytphy_modify_ext(phydev, YTPHY_WOL_CONFIG_REG, mask, val);
>
> Look at these lines. What changed?
>
> As a reviewer, i review diffs. Changes like this are just a waste of
> my time. Please review your own diffs, look for issues like this,
> solve them. I won't give comments on the actual code until these
> problems are gone.
>
Ans: sorry, the diffs issue is fixed done in patch v5.
> Andrew
>
> ---
> pw-bot: cr
prev parent reply other threads:[~2026-07-21 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:11 Kyle Switch
2026-07-20 13:48 ` Andrew Lunn
2026-07-21 11:47 ` Kyle Switch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae2384a7-1fb5-4a58-87f2-ee81ed5e6d47@motor-comm.com \
--to=kyle.switch@motor-comm.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jianmin.wang@motor-comm.com \
--cc=jie.han@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®