From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
djwong@kernel.org, john.g.garry@oracle.com, tytso@mit.edu,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: [PATCH v3 07/13] generic/1228: Add atomic write multi-fsblock O_[D]SYNC tests
Date: Sat, 12 Jul 2025 19:42:49 +0530 [thread overview]
Message-ID: <ae247b8d0a9b1309a2e4887f8dd30c1d6e479848.1752329098.git.ojaswin@linux.ibm.com> (raw)
In-Reply-To: <cover.1752329098.git.ojaswin@linux.ibm.com>
This adds various atomic write multi-fsblock stresst tests
with mixed mappings and O_SYNC, to ensure the data and metadata
is atomically persisted even if there is a shutdown.
Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
tests/generic/1228 | 139 +++++++++++++++++++++++++++++++++++++++++
tests/generic/1228.out | 2 +
2 files changed, 141 insertions(+)
create mode 100755 tests/generic/1228
create mode 100644 tests/generic/1228.out
diff --git a/tests/generic/1228 b/tests/generic/1228
new file mode 100755
index 00000000..3f9a6af1
--- /dev/null
+++ b/tests/generic/1228
@@ -0,0 +1,139 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 IBM Corporation. All Rights Reserved.
+#
+# FS QA Test 1228
+#
+# Atomic write multi-fsblock data integrity tests with mixed mappings
+# and O_SYNC
+#
+. ./common/preamble
+. ./common/atomicwrites
+_begin_fstest auto quick rw atomicwrites
+
+_require_scratch_write_atomic_multi_fsblock
+_require_atomic_write_test_commands
+_require_scratch_shutdown
+_require_xfs_io_command "truncate"
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount >> $seqres.full
+
+check_data_integrity() {
+ actual=$(_hexdump $testfile)
+ if [[ "$expected" != "$actual" ]]
+ then
+ echo "Integrity check failed"
+ echo "Integrity check failed" >> $seqres.full
+ echo "# Expected file contents:" >> $seqres.full
+ echo "$expected" >> $seqres.full
+ echo "# Actual file contents:" >> $seqres.full
+ echo "$actual" >> $seqres.full
+
+ _fail "Data integrity check failed. The atomic write was torn."
+ fi
+}
+
+prep_mixed_mapping() {
+ $XFS_IO_PROG -c "truncate 0" $testfile >> $seqres.full
+ local off=0
+ local mapping=""
+
+ local operations=("W" "H" "U")
+ local num_blocks=$((awu_max / blksz))
+ for ((i=0; i<num_blocks; i++)); do
+ local index=$((RANDOM % ${#operations[@]}))
+ local map="${operations[$index]}"
+ local mapping="${mapping}${map}"
+
+ case "$map" in
+ "W")
+ $XFS_IO_PROG -dc "pwrite -S 0x61 -b $blksz $off $blksz" $testfile > /dev/null
+ ;;
+ "H")
+ # No operation needed for hole
+ ;;
+ "U")
+ $XFS_IO_PROG -c "falloc $off $blksz" $testfile >> /dev/null
+ ;;
+ esac
+ off=$((off + blksz))
+ done
+
+ echo "+ + Mixed mapping prep done. Full mapping pattern: $mapping" >> $seqres.full
+
+ sync $testfile
+}
+
+verify_atomic_write() {
+ if [[ "$1" == "shutdown" ]]
+ then
+ local do_shutdown=1
+ fi
+
+ test $bytes_written -eq $awu_max || _fail "atomic write len=$awu_max assertion failed"
+
+ if [[ $do_shutdown -eq "1" ]]
+ then
+ echo "Shutting down filesystem" >> $seqres.full
+ _scratch_shutdown >> $seqres.full
+ _scratch_cycle_mount >>$seqres.full 2>&1 || _fail "remount failed for Test-3"
+ fi
+
+ check_data_integrity
+}
+
+mixed_mapping_test() {
+ prep_mixed_mapping
+
+ echo "+ + Performing O_DSYNC atomic write from 0 to $awu_max" >> $seqres.full
+ bytes_written=$($XFS_IO_PROG -dc "pwrite -DA -V1 -b $awu_max 0 $awu_max" $testfile | \
+ grep wrote | awk -F'[/ ]' '{print $2}')
+
+ verify_atomic_write $1
+}
+
+testfile=$SCRATCH_MNT/testfile
+touch $testfile
+
+awu_max=$(_get_atomic_write_unit_max $testfile)
+blksz=$(_get_block_size $SCRATCH_MNT)
+
+# Create an expected pattern to compare with
+$XFS_IO_PROG -tc "pwrite -b $awu_max 0 $awu_max" $testfile >> $seqres.full
+expected=$(_hexdump $testfile)
+echo "# Expected file contents:" >> $seqres.full
+echo "$expected" >> $seqres.full
+echo >> $seqres.full
+
+echo "# Test 1: Do O_DSYNC atomic write on random mixed mapping:" >> $seqres.full
+echo >> $seqres.full
+for ((iteration=1; iteration<=10; iteration++)); do
+ echo "=== Mixed Mapping Test Iteration $iteration ===" >> $seqres.full
+
+ echo "+ Testing without shutdown..." >> $seqres.full
+ mixed_mapping_test
+ echo "Passed!" >> $seqres.full
+
+ echo "+ Testing with sudden shutdown..." >> $seqres.full
+ mixed_mapping_test "shutdown"
+ echo "Passed!" >> $seqres.full
+
+ echo "Iteration $iteration completed: OK" >> $seqres.full
+ echo >> $seqres.full
+done
+echo "# Test 1: Do O_SYNC atomic write on random mixed mapping (10 iterations): OK" >> $seqres.full
+
+
+echo >> $seqres.full
+echo "# Test 2: Do extending O_SYNC atomic writes: " >> $seqres.full
+bytes_written=$($XFS_IO_PROG -dstc "pwrite -A -V1 -b $awu_max 0 $awu_max" $testfile | \
+ grep wrote | awk -F'[/ ]' '{print $2}')
+verify_atomic_write "shutdown"
+echo "# Test 2: Do extending O_SYNC atomic writes: OK" >> $seqres.full
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit
+
diff --git a/tests/generic/1228.out b/tests/generic/1228.out
new file mode 100644
index 00000000..1baffa91
--- /dev/null
+++ b/tests/generic/1228.out
@@ -0,0 +1,2 @@
+QA output created by 1228
+Silence is golden
--
2.49.0
next prev parent reply other threads:[~2025-07-12 14:13 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 14:12 [PATCH v3 00/13] Add more tests for multi fs block atomic writes Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 01/13] common/rc: Add _min() and _max() helpers Ojaswin Mujoo
2025-07-17 15:02 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 02/13] common/rc: Fix fsx for ext4 with bigalloc Ojaswin Mujoo
2025-07-17 16:11 ` Darrick J. Wong
2025-07-22 9:53 ` Ojaswin Mujoo
2025-07-23 14:50 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 03/13] common/rc: Add a helper to run fsx on a given file Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 04/13] ltp/fsx.c: Add atomic writes support to fsx Ojaswin Mujoo
2025-07-17 16:17 ` Darrick J. Wong
2025-07-22 9:59 ` Ojaswin Mujoo
2025-07-23 14:57 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 05/13] generic/1226: Add atomic write test using fio crc check verifier Ojaswin Mujoo
2025-07-17 13:00 ` John Garry
2025-07-17 13:52 ` Ojaswin Mujoo
2025-07-17 14:06 ` John Garry
2025-07-22 8:47 ` Ojaswin Mujoo
2025-07-23 11:33 ` John Garry
2025-07-23 13:51 ` Ojaswin Mujoo
2025-07-23 16:25 ` John Garry
2025-07-25 6:27 ` Ojaswin Mujoo
2025-07-25 8:14 ` John Garry
2025-07-28 6:43 ` Ojaswin Mujoo
2025-07-28 9:09 ` John Garry
2025-07-28 13:35 ` Ojaswin Mujoo
2025-07-28 14:00 ` John Garry
2025-07-29 6:11 ` Ojaswin Mujoo
2025-07-29 14:45 ` Darrick J. Wong
2025-07-31 4:18 ` Ojaswin Mujoo
2025-07-31 7:58 ` John Garry
2025-08-01 6:41 ` Ojaswin Mujoo
2025-08-01 8:23 ` John Garry
2025-08-02 6:49 ` Ojaswin Mujoo
2025-08-04 7:12 ` John Garry
2025-08-08 6:00 ` Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 06/13] generic/1227: Add atomic write test using fio verify on file mixed mappings Ojaswin Mujoo
2025-07-17 16:32 ` Darrick J. Wong
2025-07-28 8:58 ` Zorro Lang
2025-07-28 9:27 ` Ojaswin Mujoo
2025-07-12 14:12 ` Ojaswin Mujoo [this message]
2025-07-17 16:35 ` [PATCH v3 07/13] generic/1228: Add atomic write multi-fsblock O_[D]SYNC tests Darrick J. Wong
2025-07-23 13:53 ` Ojaswin Mujoo
2025-07-23 14:54 ` Darrick J. Wong
2025-08-10 9:41 ` Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 08/13] generic/1229: Stress fsx with atomic writes enabled Ojaswin Mujoo
2025-07-17 16:22 ` Darrick J. Wong
2025-07-23 6:30 ` Ojaswin Mujoo
2025-07-23 14:56 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 09/13] generic/1230: Add sudden shutdown tests for multi block atomic writes Ojaswin Mujoo
2025-07-29 19:49 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 10/13] ext4/061: Atomic writes stress test for bigalloc using fio crc verifier Ojaswin Mujoo
2025-07-29 19:47 ` Darrick J. Wong
2025-07-30 13:56 ` Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 11/13] ext4/062: Atomic writes test for bigalloc using fio crc verifier on multiple files Ojaswin Mujoo
2025-07-29 19:44 ` Darrick J. Wong
2025-07-12 14:12 ` [PATCH v3 12/13] ext4/063: Atomic write test for extent split across leaf nodes Ojaswin Mujoo
2025-07-29 19:41 ` Darrick J. Wong
2025-07-30 14:06 ` Ojaswin Mujoo
2025-07-12 14:12 ` [PATCH v3 13/13] ext4/064: Add atomic write tests for journal credit calculation Ojaswin Mujoo
2025-07-29 19:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae247b8d0a9b1309a2e4887f8dd30c1d6e479848.1752329098.git.ojaswin@linux.ibm.com \
--to=ojaswin@linux.ibm.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®