From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19EBCC32753 for ; Wed, 14 Aug 2019 13:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCFA1206C1 for ; Wed, 14 Aug 2019 13:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbfHNNZS (ORCPT ); Wed, 14 Aug 2019 09:25:18 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41071 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727654AbfHNNZS (ORCPT ); Wed, 14 Aug 2019 09:25:18 -0400 Received: by mail-wr1-f66.google.com with SMTP id j16so8821502wrr.8 for ; Wed, 14 Aug 2019 06:25:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v8bm6m3peCAV3vYnBeExpv1o4YspqypQDdeC2k7BzX8=; b=qwzDMpykwZWcGEoNzFLG0yI52VHZNPC/zrNmYTKTSWN3JG99sjFA+hnzM6L/13GNLg cpKOFrp/OuWjK/IrOJHWH1QEu3IQenTNhdR7z9+qPghtjNOyPG/2c6I7SvmT5XVS7kFd 3PXbjlRFJYiiTmsNWPmHblTiEqleJkIUvXKaqa4852Mgq88Qz8Znu1nF9YcPSX/a7dW2 aHriyoSH/H4IY+1Je9PlUGhIHbndy0Tytr6sV8XKnxs86o8VGuIUnoLWWaXO76W4bbqw oo07aCzH/wYBTl9frXE5Fe76BVEYqRXAyzgcXTUBwGZtoNK6bmM5WCoMLVKwgFvpzAiX gg/w== X-Gm-Message-State: APjAAAXG0/5XRk1Mch5YwqbDAtYQS6GyZ3TrLtPEnCfBHaXLqOEVRses D/lU5sApyrKnv/ywJg1LxSXSdQ== X-Google-Smtp-Source: APXvYqxde+YHLJmjC1TeaB9ENf1+EmXmIoLOJNZrBdqWF8VJIiPT5sc+dopQuVnlJQWITzCdKPqoIw== X-Received: by 2002:adf:cd11:: with SMTP id w17mr25787597wrm.297.1565789116116; Wed, 14 Aug 2019 06:25:16 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:2cae:66cd:dd43:92d9? ([2001:b07:6468:f312:2cae:66cd:dd43:92d9]) by smtp.gmail.com with ESMTPSA id 7sm3292854wmj.46.2019.08.14.06.25.15 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 06:25:15 -0700 (PDT) Subject: Re: [PATCH v4 0/7] x86: KVM: svm: get rid of hardcoded instructions lengths To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Jim Mattson , Sean Christopherson References: <20190813135335.25197-1-vkuznets@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: Date: Wed, 14 Aug 2019 15:25:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190813135335.25197-1-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/08/19 15:53, Vitaly Kuznetsov wrote: > Changes since v3 [Sean Christopherson]: > - add Reviewed-by tag to PATCH5 > - __skip_emulated_instruction()/skip_emulated_instruction() split, > 'unlikely(r != EMULATE_DONE)' in PATCH2 > - Make nested_svm_vmrun() return an int in PATCH6 (moved from PATCH7) > - Avoid weird-looking 'if (rc) return ret' in PATCH7 > > Original description: > > Jim rightfully complains that hardcoding instuctions lengths is not always > correct: additional (redundant) prefixes can be used. Luckily, the ugliness > is mostly harmless: modern AMD CPUs support NRIP_SAVE feature but I'd like > to clean things up and sacrifice speed in favor of correctness. Queued, thanks. Paolo