From: Shuah Khan <shuah@kernel.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Bamvor Jian Zhang <bamv2005@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/gpio: fix compiling errors
Date: Wed, 10 Oct 2018 14:25:31 -0600 [thread overview]
Message-ID: <ae288c01-5350-5b95-8157-dd377e6738b1@kernel.org> (raw)
In-Reply-To: <1372e275-d276-7982-127e-dd339ead1b67@cn.fujitsu.com>
On 10/07/2018 08:32 AM, Li Zhijian wrote:
> ping
>
>
> On 09/21/2018 06:00 PM, Li Zhijian wrote:
>> lizhijian@haswell-OptiPlex-9020:/home/lizj/linux/tools/testing/selftests$ make
>> [...snip...]
>> make ARCH=x86 CROSS_COMPILE= -C ../../../gpio
>> make[2]: Entering directory '/home/lizj/linux/tools/gpio'
>> [...snip...]
>> make[3]: Leaving directory '/home/lizj/linux/tools/gpio'
>> LINK /home/lizj/linux/tools/testing/selftests/gpiogpio-event-mon
>> make[2]: Leaving directory '/home/lizj/linux/tools/gpio'
>> gcc -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ gpio-mockup-chardev.c ../../../gpio/gpio-utils.o -lmount -I/usr/include/libmount -o gpio-mockup-chardev
>> gcc: error: ../../../gpio/gpio-utils.o: No such file or directory
>> <builtin>: recipe for target 'gpio-mockup-chardev' failed
>> make[1]: *** [gpio-mockup-chardev] Error 1
>> make[1]: Leaving directory
>> '/home/lizj/linux/tools/testing/selftests/gpio'
>> Makefile:85: recipe for target 'all' failed
>> make: *** [all] Error 2
>>
>> in this patch
>> - correct target name to $OUTPUTgpio-utils.o
>> - pass OUTPUT to tools/gpio/Makefile
>> - support cleanup ../gpiogpio-hammer.o
>>
>> CC: Bamvor Jian Zhang <bamv2005@gmail.com>
>> CC: Bartosz Golaszewski <brgl@bgdev.pl>
>> CC: Shuah Khan <shuah@kernel.org>
>> CC: linux-gpio@vger.kernel.org
>> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
>> ---
>> tools/testing/selftests/gpio/Makefile | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
>> index 4665cdb..7f9354a 100644
>> --- a/tools/testing/selftests/gpio/Makefile
>> +++ b/tools/testing/selftests/gpio/Makefile
>> @@ -7,7 +7,7 @@ EXTRA_PROGS := ../gpiogpio-event-mon ../gpiogpio-hammer ../gpiolsgpio
>> EXTRA_DIRS := ../gpioinclude/
>> EXTRA_OBJS := ../gpiogpio-event-mon-in.o ../gpiogpio-event-mon.o
>> EXTRA_OBJS += ../gpiogpio-hammer-in.o ../gpiogpio-utils.o ../gpiolsgpio-in.o
>> -EXTRA_OBJS += ../gpiolsgpio.o
>> +EXTRA_OBJS += ../gpiolsgpio.o ../gpiogpio-hammer.o
>> include ../lib.mk
>> @@ -22,7 +22,7 @@ CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/
>> LDLIBS += -lmount -I/usr/include/libmount
>> $(BINARIES):| khdr
>> -$(BINARIES): ../../../gpio/gpio-utils.o
>> +$(BINARIES): ../gpiogpio-utils.o
>> -../../../gpio/gpio-utils.o:
>> - make ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio
>> +../gpiogpio-utils.o:
>> + make OUTPUT=$(OUTPUT) ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio
>
Is this still an issue in linux-kselftest next. I applied a few patches
from Fathi Boudra
Please check and let me know if this is till an issue.
thanks,
-- Shuah
next prev parent reply other threads:[~2018-10-10 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:00 Li Zhijian
2018-10-07 14:32 ` Li Zhijian
2018-10-10 20:25 ` Shuah Khan [this message]
2018-10-11 1:24 ` Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae288c01-5350-5b95-8157-dd377e6738b1@kernel.org \
--to=shuah@kernel.org \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®