From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752048AbdJDLMb (ORCPT ); Wed, 4 Oct 2017 07:12:31 -0400 Received: from mout.web.de ([212.227.15.4]:52576 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdJDLM2 (ORCPT ); Wed, 4 Oct 2017 07:12:28 -0400 Subject: [PATCH 1/2] ARM: SAMSUNG: Delete an error message for a failed memory allocation in three functions From: SF Markus Elfring To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Kukjin Kim , Russell King Cc: LKML , kernel-janitors@vger.kernel.org References: <75c352ad-c51e-2e63-2f93-0f14522ff09c@users.sourceforge.net> Message-ID: Date: Wed, 4 Oct 2017 13:11:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <75c352ad-c51e-2e63-2f93-0f14522ff09c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:vbPw9yPrGWMovg9CFi9NlH2k/nDOQ3YcPebOCo4zRNgCnhriyGl ShsY7XBLb8JydbqQSkdrcBEEn6+iRjb1hayXtpL8KTOnytiyI4FcV2v/fp1LW/IoxJHqj47 bPAeZITNIfTqZNjnf1YAW/FBCB6rduAeymn0JIoVGY6KZxPPeL0gGh1HfsMUHt7uGPdiwyP HFg0n3m4KL0JlA/2s2cmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:HruPDKL75Cg=:IdWsOO54jqoXK2zJGITF5Y EQA87ZakFMAHCzyo/6cKglebpse9Y8Zb+4uvxSt2/LT0mo6168xsS7n97tE7G3RMBItcK+vJg BPH0y/fKSTaAFUCwh84am7aXVm01nM2YCvmBsd2qa6UxWfSPpNq/9TLRgDvym39Jtt9bLh2SH Uc9Oi8KCocD/onTUkHAedymyQKvQHQHo2ZnM+6T8qWJW4E4/+va+TVYMXwkgQ1/KANnSy3n2H ffH244+NeV/wwgPJHvrOkn1n9yGGG1C3xRW6E+XQW3JJzFBTk4FqX1DdGck7r+pge2HW6Vqf6 QXYppRwVoDwoRcaw+6gV0FVpoxCY1YVBkQcmhYnZTkrSquv5hyArRo9oLUw/f4hsXtRY3R06P sIafFkEydbG8ujh8lV7RtBMd/Rktg72UQNbEX8harebwEnS2QDO9A49GqPPkX2Q7wWcFl/xi8 1ScDfwJrVmru9AlrjCUiS7RuXP4TSo8CpCsyebOTr7cvWiRtpyxAUEHdVzCaiKiaw2Mccmkfu 7jfbqBtHhefpYTFWxLebm6mi1+zTnCo9P3+sYyuXCZpZ7AIpAXk1wCxWHuxysVNYGkdEf82rY Rw/fiiofdpCFz5rnIm/SAcwDER064i1RVxGtjeKXILyYnQ1Ie41NGCrEr9u0QeDU8Lfj78W3f ZhQhKgBt8ECDFXId4LaFNkofMriUQEYJHLwfQJAecG8Nb4rjVF8A1nZzTdYQSWoh2j5laxtCz Q7M6fOTL+aljJGJDM6uwlriYiCli4c1s146DnocDPsRILVw9AIj3cTXEV8m0y3vHL5ttjHYd9 AVYiW0gjcftf9rujJa63nEfKEzwYgPI1+ZaDvemkTUfkZR4F5E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 4 Oct 2017 09:33:52 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/plat-samsung/adc.c | 8 ++------ arch/arm/plat-samsung/platformdata.c | 4 +--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c index daf3db9f0058..f8d6206e4daa 100644 --- a/arch/arm/plat-samsung/adc.c +++ b/arch/arm/plat-samsung/adc.c @@ -239,10 +239,8 @@ struct s3c_adc_client *s3c_adc_register(struct platform_device *pdev, return ERR_PTR(-EINVAL); client = kzalloc(sizeof(struct s3c_adc_client), GFP_KERNEL); - if (!client) { - dev_err(&pdev->dev, "no memory for adc client\n"); + if (!client) return ERR_PTR(-ENOMEM); - } client->pdev = pdev; client->is_ts = is_ts; @@ -345,10 +343,8 @@ static int s3c_adc_probe(struct platform_device *pdev) unsigned tmp; adc = devm_kzalloc(dev, sizeof(struct adc_device), GFP_KERNEL); - if (adc == NULL) { - dev_err(dev, "failed to allocate adc_device\n"); + if (!adc) return -ENOMEM; - } spin_lock_init(&adc->lock); diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat-samsung/platformdata.c index b430e9946287..6cf52ee7eeec 100644 --- a/arch/arm/plat-samsung/platformdata.c +++ b/arch/arm/plat-samsung/platformdata.c @@ -29,10 +29,8 @@ void __init *s3c_set_platdata(void *pd, size_t pdsize, } npd = kmemdup(pd, pdsize, GFP_KERNEL); - if (!npd) { - printk(KERN_ERR "%s: cannot clone platform data\n", pdev->name); + if (!npd) return NULL; - } pdev->dev.platform_data = npd; return npd; -- 2.14.2