mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator out of simple-bus
Date: Thu, 20 Apr 2023 12:49:54 +0200	[thread overview]
Message-ID: <ae2d4903-9147-fe8f-1911-d49ef5a4cb51@linaro.org> (raw)
In-Reply-To: <20230420075053.41976-9-krzysztof.kozlowski@linaro.org>



On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warning:
> 
>   Warning (simple_bus_reg): /regulators/gpio-regulator: missing or empty reg/ranges property
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-msm8960-cdp.dts | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> index 8fa2befa629a..6c1bc3818883 100644
> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> @@ -15,16 +15,12 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> -	regulators {
> -		compatible = "simple-bus";
> -
> -		ext_l2: gpio-regulator {
> -			compatible = "regulator-fixed";
> -			regulator-name = "ext_l2";
> -			gpio = <&msmgpio 91 0>;
> -			startup-delay-us = <10000>;
> -			enable-active-high;
> -		};
> +	ext_l2: gpio-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ext_l2";
> +		gpio = <&msmgpio 91 0>;
> +		startup-delay-us = <10000>;
> +		enable-active-high;
>  	};
>  };
>  

  reply	other threads:[~2023-04-20 10:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  7:50 [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address Krzysztof Kozlowski
2023-04-20  7:50 ` [PATCH 02/10] ARM: dts: qcom: sdx55: correct rsc unit-address Krzysztof Kozlowski
2023-04-20 10:45   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 03/10] ARM: dts: qcom: msm8974: correct pronto unit-address Krzysztof Kozlowski
2023-04-20 10:46   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 04/10] ARM: dts: qcom: ipq8064: drop leading 0 from unit-address Krzysztof Kozlowski
2023-04-20 10:46   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 05/10] ARM: dts: qcom: ipq8064: drop invalid GCC thermal-sensor unit-address Krzysztof Kozlowski
2023-04-20 10:48   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 06/10] ARM: dts: qcom: ipq8064: correct LED node names Krzysztof Kozlowski
2023-04-20 10:48   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 07/10] ARM: dts: qcom: ipq8064: align USB node names with bindings Krzysztof Kozlowski
2023-04-20 10:48   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus Krzysztof Kozlowski
2023-04-20 10:49   ` Konrad Dybcio
2023-04-20  7:50 ` [PATCH 09/10] ARM: dts: qcom: msm8960-cdp: move regulator " Krzysztof Kozlowski
2023-04-20 10:49   ` Konrad Dybcio [this message]
2023-04-20  7:50 ` [PATCH 10/10] ARM: dts: qcom: apq8084: correct thermal sensor unit-address Krzysztof Kozlowski
2023-04-20 10:50   ` Konrad Dybcio
2023-04-20 10:45 ` [PATCH 01/10] ARM: dts: qcom: ipq4019: correct syscon unit-address Konrad Dybcio
2023-05-25  4:54 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae2d4903-9147-fe8f-1911-d49ef5a4cb51@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®