mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Youling Tang <youling.tang@linux.dev>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
	Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH] gfs2: Move i_nlink checks from gfs2_{link,rename,mkdir} to VFS layer
Date: Fri, 26 Sep 2025 13:37:34 +0800	[thread overview]
Message-ID: <ae2db4c3-3769-4945-97bc-2407a260886b@linux.dev> (raw)
In-Reply-To: <20250926044854.GD39973@ZenIV>

On 9/26/25 12:48, Al Viro wrote:

> On Fri, Sep 26, 2025 at 10:56:04AM +0800, Youling Tang wrote:
>> From: Youling Tang <tangyouling@kylinos.cn>
>>
>> vfs_{link, rename, mkdir} will check i_nlink. When sb->s_max_links is set,
>> set sb->s_max_links in gfs2 to simplify the code.
> For gfs2 you are going to run into a problem - link count is not stable until
> you take gfs2 locks; checks in vfs_link() et.al. will be inevitably racy for
> cluster filesystems.

Thank you for pointing out this important issue. Let's discard this patch.

Thanks,
Youling.

      reply	other threads:[~2025-09-26  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  2:56 Youling Tang
2025-09-26  4:48 ` Al Viro
2025-09-26  5:37   ` Youling Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae2db4c3-3769-4945-97bc-2407a260886b@linux.dev \
    --to=youling.tang@linux.dev \
    --cc=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tangyouling@kylinos.cn \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®