mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Anastasov <ja@ssi.bg>
To: Rosen Penev <rosenp@gmail.com>
Cc: netfilter-devel@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"open list:IPVS" <netdev@vger.kernel.org>,
	"open list:IPVS" <lvs-devel@vger.kernel.org>,
	"open list:NETFILTER" <coreteam@netfilter.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipvs: Use flexible array for MH lookup table
Date: Fri, 22 May 2026 20:12:31 +0300 (EEST)	[thread overview]
Message-ID: <ae2ed619-0562-afd8-1141-56116e9da68d@ssi.bg> (raw)
In-Reply-To: <20260519015506.634185-1-rosenp@gmail.com>


	Hello,

On Mon, 18 May 2026, Rosen Penev wrote:

> Store the Maglev hash lookup table in the scheduler state
> allocation instead of allocating it separately.
> 
> This keeps the lookup table tied to the RCU-freed state lifetime and
> simplifies the allocation and cleanup paths.
> 
> Assisted-by: Codex:GPT-5.5
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

	Thanks for the efforts but it is better to keep the table 
allocated separately. As Sashiko [1] points out, the table size is
properly selected and we risk double-sized allocations if we apply
this patch.

	As for the problem in ip_vs_edit_service(), I have to
provide separate bugfix...

[1]:
https://sashiko.dev/#/patchset/20260519015506.634185-1-rosenp%40gmail.com

Regards

--
Julian Anastasov <ja@ssi.bg>


      parent reply	other threads:[~2026-05-22 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  1:55 Rosen Penev
2026-05-19 17:08 ` Julian Anastasov
2026-05-22 17:12 ` Julian Anastasov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae2ed619-0562-afd8-1141-56116e9da68d@ssi.bg \
    --to=ja@ssi.bg \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@verge.net.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®