From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6455636CDFD for ; Fri, 10 Jul 2026 13:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783689085; cv=none; b=abnynh3jN/ivdRqTEfVOEgS1RsXnNWApIQ4h6OpWTem7LEAYP1V7E2mIamVWoi9iPyw4TWgDGyjeBFEHgNX0VPLQMMUf0DW8Yu+W61IE3VCD5XD4xaOD/rJ8UVSOwoqWj3C6TyU246H+4xgiSi4gnGEnhhrzzAwb4wD/Nos8JxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783689085; c=relaxed/simple; bh=ZdgRmOe8iNqFJWCLTga+TYvk/2JfUynFYqqOMIxvIkA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=agwIslzOCCZuz+Hp5BLxym5/hyYHml5y6svS2BGn+0wtTLyRgunF/rakGno4SE9J5DTtkEFuvxZCYzyHXi/MPgvn4RCp2fVXs5iiAs+pNoapYYuPGQ/xoAwy1cEFEaoaF7Yo1dFY1HK5tGQnNxzim3StH1aki0D9r5QOcg9qdqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Y6/GfzwW; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=3LsQR5LS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fH4WDjjj; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=s0NnleWO; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Y6/GfzwW"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="3LsQR5LS"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fH4WDjjj"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="s0NnleWO" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6355876470; Fri, 10 Jul 2026 13:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783689082; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mocC1RLiQ5k5FcH+1mibmIQtg6g+ccUJPi4jIEkgVT4=; b=Y6/GfzwWVuhFwG6I497hxqHovoxT6p0C9qLaSRJmBJr4KdqTotJGEfNNGCJXc4pivx94Jp Fk0duvDpLuNpmup/ng634JxIt/51dSJnlju4J8HMcc0q60VnMxw5epsLPDY8hJM3rdLmUd Jo7eAZHVznfpBhyx56Lew3Bd8BIysss= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783689082; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mocC1RLiQ5k5FcH+1mibmIQtg6g+ccUJPi4jIEkgVT4=; b=3LsQR5LSmfqvvPTk7lAmf3QzT2wl3Vt3URRes6tmtQInbKRpuBFOokmalWTmzkqzIy1NjB 4MH0Yztb6qLeztAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fH4WDjjj; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=s0NnleWO DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783689081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mocC1RLiQ5k5FcH+1mibmIQtg6g+ccUJPi4jIEkgVT4=; b=fH4WDjjjct4n/EfYWSsFSRhjfbemfrNoLQPKQokR32uSoi8UBjo47dWCZZyliZPcxaEDP0 RB4LkBWkm4ACebR7D1NeicmfBP25Z7DmnP0p00o+cweSBwlbW6urHkjk2FQmfmcyUbYNJ8 vugc6bYFjekzmvAj218Adhg+pQidZ+M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783689081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mocC1RLiQ5k5FcH+1mibmIQtg6g+ccUJPi4jIEkgVT4=; b=s0NnleWOmoTgVq7TkBpMaI9EIE8RF/qKVDvQT72yZR5yutn738p5cAFn0JRoeX/Ptezp2E PXFKO/YTqwHToaBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15D5B779BD; Fri, 10 Jul 2026 13:11:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bAb+A3nvUGpQeQAAD6G6ig (envelope-from ); Fri, 10 Jul 2026 13:11:21 +0000 Message-ID: Date: Fri, 10 Jul 2026 15:11:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/qxl: remove dependency on DRM simple helpers From: Thomas Zimmermann To: Diogo Silva , Dave Airlie , Gerd Hoffmann , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260707-qxl-simple-v2-1-08d21bc74a41@gmail.com> <18186cbc-a60c-4a1a-95f5-46e392faa997@suse.de> Content-Language: en-US Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <18186cbc-a60c-4a1a-95f5-46e392faa997@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,redhat.com,linux.intel.com,kernel.org,ffwll.ch]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[11]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid,suse.com:url] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 6355876470 X-Spam-Score: -4.51 Merged into drm-misc-next Am 08.07.26 um 14:33 schrieb Thomas Zimmermann: > > > Am 07.07.26 um 18:14 schrieb Diogo Silva: >> Simple KMS helper are deprecated since they only add an intermediate >> layer between drivers and the atomic modesetting. >> This patch removes the drm_simple_encoder_init() helper usage in the >> qxl display driver by open coding it and using the encoder atomic >> helpers directly. This is a step to eventually get rid of this simple >> KMS helper, once all drivers that use it have been converted. >> >> Signed-off-by: Diogo Silva > > Reviewed-by: Thomas Zimmermann > >> --- >> Changes in v2: >> - fix type error >> - Link to v1: >> https://lore.kernel.org/r/20260707-qxl-simple-v1-1-524f6316b5d5@gmail.com >> --- >>   drivers/gpu/drm/qxl/qxl_display.c | 12 ++++++++---- >>   1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/qxl/qxl_display.c >> b/drivers/gpu/drm/qxl/qxl_display.c >> index a026bd35ef485..7f4178800afd7 100644 >> --- a/drivers/gpu/drm/qxl/qxl_display.c >> +++ b/drivers/gpu/drm/qxl/qxl_display.c >> @@ -31,12 +31,12 @@ >>   #include >>   #include >>   #include >> +#include >>   #include >>   #include >>   #include >>   #include >>   #include >> -#include >>   #include >>   #include >>   #include >> @@ -1095,6 +1095,10 @@ static const struct drm_connector_helper_funcs >> qxl_connector_helper_funcs = { >>       .best_encoder = qxl_best_encoder, >>   }; >>   +static const struct drm_encoder_funcs qxl_encoder_funcs = { >> +    .destroy = drm_encoder_cleanup, >> +}; >> + >>   static enum drm_connector_status qxl_conn_detect( >>               struct drm_connector *connector, >>               bool force) >> @@ -1169,10 +1173,10 @@ static int qdev_output_init(struct drm_device >> *dev, int num_output) >>       drm_connector_init(dev, &qxl_output->base, >>                  &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); >>   -    ret = drm_simple_encoder_init(dev, &qxl_output->enc, >> -                      DRM_MODE_ENCODER_VIRTUAL); >> +    ret = drm_encoder_init(dev, &qxl_output->enc, &qxl_encoder_funcs, >> +                   DRM_MODE_ENCODER_VIRTUAL, NULL); >>       if (ret) { >> -        drm_err(dev, "drm_simple_encoder_init() failed, error %d\n", >> +        drm_err(dev, "drm_encoder_init() failed, error %d\n", >>               ret); >>           goto err_drm_connector_cleanup; >>       } >> >> --- >> base-commit: ee2867b79f9bac3a6fc3221139b09598ce79099c >> change-id: 20260707-qxl-simple-c01aa1a5c4eb >> >> Best regards, > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)