From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2C5330339 for ; Thu, 19 Mar 2026 11:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921476; cv=none; b=R0FESVChwaTxrhbkQYNYIfpj92rwQzRK/ZNbVA+1OPMCiEZzl057Xm9MtWHRzsDJDhiUNtAjVL41FKbCF/zAxgTbPpKbJdbEnbvaqI4YkGuW+lMc8yDPmekCGJmTB3dDZsQPThUugvWI05hdr81F8SmJHleQMWh0vP+JxCiyykw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773921476; c=relaxed/simple; bh=yC6Ijh7vCR3XdkIrIV9yo00I9p5DCq5XZe85XCd2G6Q=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EAEaziU9vbWGyarRIBsT+oFfP3h1hK6HX3ZZnsUJzIH2iUwYwEwuayI6GFLa0kLibeKwom3O4p4w/W1+IoawSiZZxQQBfsuWyabGN5BKTLJEAU8NtqYf/tVBftCIEcJeP0JxFsxvffnJJw5bsMyKoMDoEVB4kzjcJOvImNt96/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N3+croW1; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N3+croW1" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4856cd3f1ffso8866815e9.3 for ; Thu, 19 Mar 2026 04:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773921470; x=1774526270; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=yC6Ijh7vCR3XdkIrIV9yo00I9p5DCq5XZe85XCd2G6Q=; b=N3+croW1c7ST5J6EHCB6cZhFtMCt3CFujblmcv9rU+YpIk5XbBR7diwuQ9dh88r5Ea s3gpqHoWW/GSSXNBsouH2LvA8pngRkWNIs2r20VG9PggrPD0vNOSaFMq3rN/QVG+As5l wMaSiQStyFr0Jn7eIup6GYOlWjWol6h7EBW9ET0Kwn4QNrqch89DBtvndzZb68YUUejZ 1TSRsHd2hNlmRIuTCrnOvIzO3cHXU5gUQmRdoTAnlYn2CXegZolOwJgphhcl4uU+mQR2 /Vd7L58+mMQ7pFJl/q4fEDrjyMQnTdXH6MrY4FgYc5wDz5EzvW3AqRxoZEgbK49bya/N rZpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773921470; x=1774526270; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yC6Ijh7vCR3XdkIrIV9yo00I9p5DCq5XZe85XCd2G6Q=; b=dIAt3rI6MW9cin/z6vfSxtghGJ0dzaUpCDZupZcfU1sLDenigX/f4mxMkZNWxA6WUq AdBNAjnnBRnAvP8V+vGokTq262o2fB7qqOCf1DFhJp9+4tCGas7zb3E/fJUUAF1hXdb2 bT9NFOXoMF2+GSMcx0+0SdUquCbk8TAflUrq7el8yGkj4V9wuTzFOFv4+gkeW8IOo/sr MYYSVw99K+LO89OOfUxI3DqzBZFer6+l34NVM1UX1/qU/GwfG+q4zqVy86maVMxyNML0 E9Uihkv0ATIkuMITObnpTTI71B2f8bsh3ES5133bv13+TM4GzMfHV+haDWHEKXgkHM+9 appA== X-Forwarded-Encrypted: i=1; AJvYcCVT+xIZ1NfSWpewp+E4QK9hS1agCdNfZ3gnMsvYfTFnaN6OPYIFDfxmUMpt8un2OTmslQCO/thPmvyPqeU=@vger.kernel.org X-Gm-Message-State: AOJu0YwkMaNgzJCbD3RLW7DGO7M/AHouUsO8GU27EgNKbc0Zc5o0gmcG vVspvJ7ku2FRcHkMl2AJVkv07Na+ouGgEtWtMbvQsQhqWZUATTAR6c3rNxFi04sNvq4= X-Gm-Gg: ATEYQzwC+/xtRBZ1eiQfwPBGEGWvsLa7WvDrfWyzQFwC4whyk23ecf5Vxzr6PKKmAsW d/y/usYJkPcPDqPWF79nT1iDScxY5MGGNlRlQqxvV0C5qF87BhG6ETpxXGXWTN67N38Ett+CTiD SwXvi+c+7GmEAqDQ4thNtnoZNbVzDpIJnxMeaC6Rp8SMQIP94Ud+RKmpvv2M2HHNIISQz9UGMfH jpfR224TNvhakgCzoWQ3zeyAYHhBCUC4GQMYG84G78YvjEoV3UDEbarA040g5Ku2NI3kOjlJW86 3wQMIDXgekKU0+PGytVg0Pt6DvDGqqm/dySEW3xwZ/ct+0tFoH0NEqZmcQ3lCKHuTx5s4NTg500 EWeslzFauOwGRGE6Nm47PitbQ/ArLQ+THIM6MfGEdF/cf4sIciRqOSOM+D7pekGOACc6+XeAtdV 9RIlqixbXigHbPvrChEbvdEJg9PUo= X-Received: by 2002:a05:600c:1992:b0:486:fad0:b166 with SMTP id 5b1f17b1804b1-486fad0b2c8mr30813105e9.17.1773921470276; Thu, 19 Mar 2026 04:57:50 -0700 (PDT) Received: from draszik.lan ([212.129.73.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8bd5f7csm65030485e9.0.2026.03.19.04.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 04:57:49 -0700 (PDT) Message-ID: Subject: Re: [PATCH v8 05/10] pmdomain: samsung: convert to using regmap From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Marek Szyprowski , Ulf Hansson Cc: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Thu, 19 Mar 2026 11:58:45 +0000 In-Reply-To: References: <20260318-gs101-pd-v8-0-241523460b10@linaro.org> <20260318-gs101-pd-v8-5-241523460b10@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8+build1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Marek, On Thu, 2026-03-19 at 11:29 +0100, Marek Szyprowski wrote: > On 19.03.2026 11:13, Ulf Hansson wrote: > > As a follow-up patch on top, please consider converting the open-coded > > polling loop above into a readx_poll_timeout_atomic(). >=20 > This has been tried and it doesn't work in all cases required for power= =20 > domain driver: >=20 > https://lore.kernel.org/all/5c19e4ef-c4fd-4bf5-88b3-46c86751b14e@samsung.= com/ >=20 > Probably a comment about that could be added directly to this code to=20 > avoid such conversion and breakage in the future. I am planning to revisit this in the future and am hoping that we can figure out what goes wrong when using regmap_read_poll_timeout(). Hopefully such a comment would only be short-lived, so maybe not really worth it? I can add it, though, if you prefer. Cheers, Andre'