From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E01DD1DE2BA for ; Sat, 21 Dec 2024 08:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734770199; cv=none; b=Cu16BCsIq+QI34qDbOzEMtdqqMRE1N1Iht4I1evj9vYN33Vj0i4ESlGlFAOxGYUoiDsL30vwjUGx41vyu5Iz2vYn4v0pmeNBoI+cdbKLt2c2WjJpuIxVaGOR24yjL/EJGFlfxW6R1D6Et+u5ZEzElF6nJKnE+Vzpp+98SpRhKd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734770199; c=relaxed/simple; bh=zq3FSIPvqai8PSLZbc+wQrZwG3OyZj3VS22c3TEhcvQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AawQQqzoLnoD7aFOYdXJJJ4R6hO/Kg3c92OtjaaK/lfHkul8sXuY69YlQHPqV8VrlaIRx7cR8XcomdG+aeSFC/fg/yFK50majZJHuDjfi5t3N01lfj8hjgjPmbS2ENybarwNx8ZSd54KLpTz60CO2SoERpogfwlq7preQahHpcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YtBu+m2l; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YtBu+m2l" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2ef6ee55225so286866a91.0 for ; Sat, 21 Dec 2024 00:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734770197; x=1735374997; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxlozA5WyOTr/v1vw9MOVplJHdPgAXlfgvmtt+Wtfs8=; b=YtBu+m2liLALd8p60rfMX2d4MxUpJmy0zaTnPNBMQ8eD69rMSCOHmcv52XoUVjQnrJ KApi958VMij0hSX4CAUMaepcqSNACpQgi6G+hiN+XKDRnjapYmz3AtWe6TEGcSQ5Zzye 1v1IXABqb92QyAPZFTuuaN2QQQctaNuG0qMMuBzfPzELC6auvqka23YYppnUmp4KeHRB CuzCaHoby1vDVQo/RvnzDE9Z3GZVxMKHRbKPEEpZ9xn3VDH0FDTsyq9thGFIf9++EEtA Y2syRwfv1aAKGsK56+D7c0kFFOvGqnabT7dV0hQk85eDUAc38LY8PS9oyK/EhKfw3+dU s9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734770197; x=1735374997; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AxlozA5WyOTr/v1vw9MOVplJHdPgAXlfgvmtt+Wtfs8=; b=YJ8cGKlwoAavdSXXCkcBodI6vLVZ6nA6xAdEXwHhVE89m2oonWHw6BaBuhxa+fNah2 /N528CNrB3TQDbye9A2BGKn3jBoSdomx06kZYMFOP7sHCC0o+ohR+xy82R/PH84We2K+ nFwjMoWdHlLy5h0pklqwXIJhHLGGxa81qvO/XQJW3oRTVCDOu+HlrvSndhScR2e0xsyP nhWXdRQjtEjRDbzVsKTzyKdILeut5U3MPgAI+sJyZxdp/L+xpNbEFVPkmoWL7rv4VZjo Rd7qf4ShznpGztNDckVYXcQ4/ghye3YZC6rpI/8ZX8k8FjXsXBpDwXhJOogiz98Pno// 5lTg== X-Forwarded-Encrypted: i=1; AJvYcCX/ok+/a/By6mK1FgHgYfqtAuO1j7lkxwc8ucP18eCE7c8whxrqrX5r0V6Rjl5Nln3UTh8zGCWvKxzl018=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2AcxSsuiD7C1AQYrFOtP6Arzi8fi9FUIbpfpn02avtousoJx8 Bcj+bGyuU9SLXG6EE4ECA55stI6niO9T/Zu/fR5fUzGDGiegWaZQ X-Gm-Gg: ASbGncsJcEiSCuFntdGl3F49oyr3cjxYecuy11vRrBEklB8wcrgfZ+aitLoOUqj+Yfg felyDEtNYq97oixW3H4oz19ko+aX4IpOg/5hHExtQJkxAnpM8e92+ywoEnN5H9pZcXPJM9dHy4a u1Rb9mFyxERkPl5XJufmvG9rIklozf4r2NDE1mlXqdh/Mk8pUVkK6zQmUHAQKoSg7PSkrNeIDm1 mkaMpNFz01JJvheJkA+lkaEP83jbMWWmK+nJEJTW8VitJMHkOPnyP0SX5+z5aqr2aE= X-Google-Smtp-Source: AGHT+IHfPptDWXU2iZpfQorvLeoxW3Z2/t+8siyIlERnOkmkaRDld+ziB3FVxh1vwQ9WaYu7HfgUQg== X-Received: by 2002:a05:6a21:58b:b0:1cf:4dae:2258 with SMTP id adf61e73a8af0-1e5e045823dmr3774779637.2.1734770196972; Sat, 21 Dec 2024 00:36:36 -0800 (PST) Received: from [192.168.1.19] ([171.76.86.134]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842dc7ed96bsm3969465a12.61.2024.12.21.00.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Dec 2024 00:36:36 -0800 (PST) Message-ID: Date: Sat, 21 Dec 2024 14:06:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] staging: gpib: cb7210: Add error handling To: Greg KH Cc: dpenkler@gmail.com, dan.carpenter@linaro.org, roheetchavan@gmail.com, arnd@arndb.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20241221022632.20931-1-niharchaithanya@gmail.com> <2024122158-bunch-critter-0696@gregkh> Content-Language: en-US From: Nihar Chaithanya In-Reply-To: <2024122158-bunch-critter-0696@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/12/24 13:21, Greg KH wrote: > On Sat, Dec 21, 2024 at 07:56:33AM +0530, Nihar Chaithanya wrote: >> The if condition in cb7210_init_module() would always fail as >> the value of err is constantly 0. >> Add error handling to cb_pcmcia_init_module() where it returns >> appropriate error code if pcmcia_register_driver() fails. >> >> This issue was reported by Coverity Scan. >> Report: >> >> CID 1635894: (#1 of 1): 'Constant' variable guards dead code (DEADCODE) >> dead_error_line: Execution cannot reach this statement: return -1;. >> >> Signed-off-by: Nihar Chaithanya >> --- >> drivers/staging/gpib/cb7210/cb7210.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/gpib/cb7210/cb7210.c b/drivers/staging/gpib/cb7210/cb7210.c >> index 63df7f3eb3f3..b2f6ad70ccaf 100644 >> --- a/drivers/staging/gpib/cb7210/cb7210.c >> +++ b/drivers/staging/gpib/cb7210/cb7210.c >> @@ -1353,7 +1353,11 @@ static struct pcmcia_driver cb_gpib_cs_driver = { >> >> int cb_pcmcia_init_module(void) >> { >> - pcmcia_register_driver(&cb_gpib_cs_driver); >> + int ret; >> + >> + ret = pcmcia_register_driver(&cb_gpib_cs_driver); >> + if (ret < 0) >> + return ret; >> return 0; > Why not make this whole function just one line? And then, as it's one > line, why is it a function at all? > > thanks, > > greg k-h Hi Greg, yes, this redundant cb_pcmcia_init_module() can be replaced with pcmcia_register_driver() where it's being called. I'll send the version 2 making these changes. Thank you, Nihar