mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Pan Bian <bianpan2016@163.com>,
	Asai Thambi SP <asamymuthupa@micron.com>,
	Selvan Mani <smani@micron.com>,
	Rajesh Kumar Sambandam <rsambandam@micron.com>,
	Vignesh Gunasekaran <vgunasekaran@micron.com>,
	Baoyou Xie <baoyou.xie@linaro.org>,
	Keith Busch <keith.busch@intel.com>,
	"Mike Christie" <mchristi@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] block: mtip32xx: set error code on failure
Date: Thu, 1 Dec 2016 08:01:58 -0700	[thread overview]
Message-ID: <ae325a8d-cd91-b8d1-17f5-85613e9a4b10@fb.com> (raw)
In-Reply-To: <1480558246-19015-1-git-send-email-bianpan2016@163.com>

On 11/30/2016 07:10 PM, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188531. In function
> mtip_block_initialize(), variable rv takes the return value, and its
> value should be negative on errors. rv is initialized as 0 and is not
> reset when the call to ida_pre_get() fails. So 0 may be returned.
> The return value 0 indicates that there is no error, which may be
> inconsistent with the execution status. This patch fixes the bug by
> explicitly assigning -ENOMEM to rv on the branch that ida_pre_get()
> fails.

Thanks, applied for 4.10.

-- 
Jens Axboe

      reply	other threads:[~2016-12-01 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  2:10 Pan Bian
2016-12-01 15:01 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae325a8d-cd91-b8d1-17f5-85613e9a4b10@fb.com \
    --to=axboe@fb.com \
    --cc=asamymuthupa@micron.com \
    --cc=baoyou.xie@linaro.org \
    --cc=bianpan2016@163.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchristi@redhat.com \
    --cc=rsambandam@micron.com \
    --cc=smani@micron.com \
    --cc=vgunasekaran@micron.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®