From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE47EDEC73 for ; Wed, 13 Sep 2023 15:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjIMPdL (ORCPT ); Wed, 13 Sep 2023 11:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjIMPdK (ORCPT ); Wed, 13 Sep 2023 11:33:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D06FB93; Wed, 13 Sep 2023 08:33:06 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDB9CC433C8; Wed, 13 Sep 2023 15:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694619186; bh=w4eOXdxxEVpvJRthlhaH92nifcMz3GmSivudS7jagvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CSdc05swdFI+Usg6TPK+loCrKdjcCDoD1l3eV91+bwpg9zqRnvz5+aPx2ibFa2Fo+ uRXQRALXPUo+Ctds8aJoAih2KTot+U3jqSStD6Ik+9HHGu73OA7p0UXd476CdW2ebO sq7OXF18Qa4JIGGYdSmXiZeHIrRv2Lp/1p4E4FTtArHa4yvdivVEZsS3XuE3c8a7tK UkuqyAMJOc7oxW6WwGVXFKy+fnXsrgER+81eHlo5tvcZ1abF082K1Wahmkkkt4hXM+ Ixh57M0SW2OStwN98jdOiHFiTDnEKlVpltLqON9IY6n7Aln2jSEuwLkRHH8rDaoxIG hxNzcOcJ7MpmA== Date: Wed, 13 Sep 2023 16:33:00 +0100 From: Mark Brown To: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado Cc: Takashi Iwai , kernel@collabora.com, Jaroslav Kysela , Shuah Khan , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/alsa: Mark test plan as skipped when no cards are available Message-ID: References: <20230908181242.95714-1-nfraprado@collabora.com> <0fa0901e-d271-438d-bc2b-11399ad3b07c@sirena.org.uk> <868a8f08-ba39-4550-8e7b-0572ea03c4e7@notapiano> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HVlTO/OC556kjwhz" Content-Disposition: inline In-Reply-To: X-Cookie: Use extra care when cleaning on stairs. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HVlTO/OC556kjwhz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 12, 2023 at 03:23:34PM -0400, N=EDcolas F. R. A. Prado wrote: > On Mon, Sep 11, 2023 at 03:29:00PM +0100, Mark Brown wrote: > > So, I would interpret the overall result for the suite as being "No > > errors were found in any of the cards discovered" if there is no > > configuration file specified which enumerates the set of cards that are > > expected (if there is a config file that's a different matter, we know > > what we're expecting). I'm not sure that the different behaviour for 0 > > cards is super useful. > Right... So what we want to be doing is adding a config file for every pl= atform > defining the card(s) and PCMs expected, so that when they're missing a te= st > failure will be triggered which is even more helpful. Although I've notic= ed that > only missing PCMs are detected currently, but I imagine it should be poss= ible to > to extend the code to detect missing cards as well. It seems like a reasonable approach for systems that do want to have this confirmation. > I take it the intention is to expand the conf.d directory with configs fo= r all > platforms currently being tested then? There's only one example file ther= e so I > wasn't sure. I think it's a question for people working on individual systems if they want that coverage, for example I don't really care for the things in my CI because I have higher level stuff which will notice any newly missing tests so I don't need the test to do anything here. --HVlTO/OC556kjwhz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUB1isACgkQJNaLcl1U h9B5dgf/cLXB70t6XRr3Q6R/yRGtT8S2hofbEAcc5/fjzyJfBGpuC9e2QDtn43LX nz2xx0PD72h2gg4yD3s80zc4wiGHOSaPAeDVCS/7VmxA37k18yP7pinIl/0LM+3s 6vAOZvpQCRqNjIWJo9F/2/FfUVTKkYZ6rhXPfsTLG2de4U2oTe3zi5qc5/4hBpTh PteqY+OK6m6/27zm3uva3vJml6vnpeofBwo+IHp6+RYLMcF1xWw3rJFv4VlOSGOf GgbfY5xaOqnTHaCGVGRqQhQXRly3/iKRqv+goyPm/s/0PFgQfzIWtot9O0+0OIum 4v44q+DWxTLjtgGlJh0VINsZdWiBFw== =ivXT -----END PGP SIGNATURE----- --HVlTO/OC556kjwhz--