From: Larry Finger <Larry.Finger@lwfinger.net>
To: Justin Vreeland <justin@jvreeland.com>,
gregkh@linuxfoundation.org, hadess@hadess.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses
Date: Thu, 27 Apr 2017 19:20:58 -0500 [thread overview]
Message-ID: <ae39b3ba-bfeb-9507-2323-991eea2d09f3@lwfinger.net> (raw)
In-Reply-To: <20170428001000.7241-4-justin@jvreeland.com>
On 04/27/2017 07:09 PM, Justin Vreeland wrote:
> Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> drivers/staging/rtl8723bs/hal/odm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
> index 0b3541a91548..13c4aebd178e 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -209,7 +209,7 @@ typedef struct _ODM_RATE_ADAPTIVE {
>
> #define AVG_THERMAL_NUM 8
> #define IQK_Matrix_REG_NUM 8
> -#define IQK_Matrix_Settings_NUM 14+24+21 /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
> +#define IQK_Matrix_Settings_NUM (14+24+21) /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
You should also put spaces around the plus signs, and fix the lines with more
then 80 columns.
The comment about non-blank commit messages also applies.
Larry
>
> #define DM_Type_ByFW 0
> #define DM_Type_ByDriver 1
>
next prev parent reply other threads:[~2017-04-28 0:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 0:09 [PATCH 0/7] staging: rtl8732: Various checkpatch fixes Justin Vreeland
2017-04-28 0:09 ` [PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables Justin Vreeland
2017-04-28 0:09 ` [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop Justin Vreeland
2017-04-28 0:19 ` Larry Finger
2017-04-28 0:09 ` [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses Justin Vreeland
2017-04-28 0:20 ` Larry Finger [this message]
2017-04-28 0:09 ` [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland
2017-04-28 0:22 ` Larry Finger
2017-04-28 0:27 ` Joe Perches
2017-04-28 0:09 ` [PATCH 5/7] staging: rtl8723bs: Fix pointer style Justin Vreeland
2017-04-28 0:09 ` [PATCH 6/7] staging: rtl8723bs: Fix spacing around '<' Justin Vreeland
2017-04-28 0:10 ` [PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition Justin Vreeland
2017-04-28 9:49 ` [PATCH 0/7] staging: rtl8732: Various checkpatch fixes Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae39b3ba-bfeb-9507-2323-991eea2d09f3@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=justin@jvreeland.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®