mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pei Xiao <xiaopei01@kylinos.cn>
To: xiaopeitux@foxmail.com, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty/sysrq: make sysrq_replay_logs_op const
Date: Fri, 11 Apr 2025 17:18:22 +0800	[thread overview]
Message-ID: <ae40b4bc-4635-4b5d-bc2a-4c304605e3a1@kylinos.cn> (raw)
In-Reply-To: <tencent_E7CD9DB87A448073E350F9400678ED9F9C0A@qq.com>

在 2025/4/3 16:38, xiaopeitux@foxmail.com 写道:

> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> Mark sysrq_replay_logs_op as const, preventing accidental modification.
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>  drivers/tty/sysrq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index f85ce02e4725..e9ada1c14e26 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -454,7 +454,7 @@ static void sysrq_handle_replay_logs(u8 key)
>  {
>  	console_try_replay_all();
>  }
> -static struct sysrq_key_op sysrq_replay_logs_op = {
> +static const struct sysrq_key_op sysrq_replay_logs_op = {
>  	.handler        = sysrq_handle_replay_logs,
>  	.help_msg       = "replay-kernel-logs(R)",
>  	.action_msg     = "Replay kernel logs on consoles",

now, split into a single patch.

Thanks!

Pei.


      parent reply	other threads:[~2025-04-11  9:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  8:38 xiaopeitux
2025-04-03  8:45 ` Greg KH
2025-04-11  9:18 ` Pei Xiao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae40b4bc-4635-4b5d-bc2a-4c304605e3a1@kylinos.cn \
    --to=xiaopei01@kylinos.cn \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=xiaopeitux@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®