From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C283002AF for ; Mon, 1 Dec 2025 09:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581304; cv=none; b=MBobbP9pKgBV+Ki7vUealSlqpQjSeKu32KH3j0GG7Wl/YT77R6upa76T+7fh9pFuQ2rHIGkCVfpHbyktKxwIFKg9GLqzcS/k1POn6Xlc3XFBp/M64CRrj9KOS7k8nzpK6nBr/Wl0SRU0gg2nG3zzqU88ZOCQUJlKcDwYiy+S1tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581304; c=relaxed/simple; bh=XeJ+8BY6Z0qO3voOXidYlNL9h2fMDUt+xyiiBSqTOl8=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=cmKOb7xqXV3fvpxyviAmn8TlXdErPJFcNwoJ3wlOKiHEg6K7pMfvbkArWKavsnCCnvR7ohXMEa3+3WlEkx+dfKDpmKZ3w2SnGRpJrLNGmY/YF9+69qfNj5TW/vesF65b6vejhn19XyHPIXRJWVMYY1QLFOvIWCjbi+kHRL+ssV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AsgT+etL; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AsgT+etL" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-477a219db05so24145255e9.2 for ; Mon, 01 Dec 2025 01:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764581300; x=1765186100; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=YWM5gUAC6NLggoknpU66m7hHs6PatxwsNQf7bof+L+g=; b=AsgT+etLvLxMDDfRHoPj/0nXgk19LsdLRj+3fm+tRp1VKilik9pRQv5uEH/OSybmVB +S+faL4VUT1mPc/rUaYfSJtM3c6ntMtdPX7ChJSHig2jeiUGEQElEigV+tAgrgMK34hS GEz6a6D4s7IcE7PL6mtKuiJm50jfXrZMxvlCCifCecBlKmIpXUeNZB5qaoucYUMEaMAw NUnvBcMrA2sB4yBlLXGmfO5thCsHr6Zr/AUHhBN7Rj3kcAEWCEcs1a8fX8mrHkepy070 REMauT5wfdLwfG5Pbgg5IxD2P7Ui18zNh/42tiDQxPvgkKVjjBtRDFh1VhdT9G2XuPuq nHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764581300; x=1765186100; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YWM5gUAC6NLggoknpU66m7hHs6PatxwsNQf7bof+L+g=; b=AVsrwTzeGQGIEtK1rXxtU00EIhwZTR4EZKPU9Zw9+e72xvK+0ye7F6PeR7QlncbtfA RAGc1kiNesdHPC/zWHAe82bFrRCgMleNzPScAZf718VB3msbwoBaf1qN3Dw7Bl15pk42 CMI4iuAESnLuniZ3CAMvo0vCRvJsjEcdHPVGbO9r50R7I6P0p3wZYt/W0W2HPDJy//T7 7b/KfphdiSXNUF0d4AV5Y1H7o4C4E+zgrRnRgKsikSTeHYXkUzlOnb4ILOnUdikFNAbz Pmm12G1S95bLvFkk6H/HRqOTueB6Kc5ycJpISIdtSxUb8WW2DJo2d6ocOCsHbu/Rl95n hLtA== X-Forwarded-Encrypted: i=1; AJvYcCVyIoM5Qo7E9WHa3TZukeoVlgpVT8u6FBJFUWGwOy4C4ouSuZ2VmBGH7UEbdNii33Z2l06FwCQp4dpWpuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwNNQvLIdCJTCQxKiee1jZEJhuttrZQc2rvGU32+irlGiEfpmWe 0xnJl3LBt69XGnZJc4/oK7LP2bSxD5MDrAmgOwNQufzr4BCcGCneA2/p X-Gm-Gg: ASbGnctozIFRqd76nARBR2d3q/2l28J+ghRHNovzR6YAgU0YYRdK4e0p9Vz4lV6Adqi Vf80oV4ijjj9SERfS9mTAnzXbz69lnlTQZXbNmDvcKxg9Fp3G7sfIjxqyv/kd1TLhQ8GspIJrD1 ffDmfOjJCj4IRp+atBNdxYBzZ/g5DTneCMwp44lVGzjccLn1Dbq7/DjiP7x+IZKD5/zKeY8Fy0x J3g9mMiW5RpY/vsg2PDhZ2Ju3DClVePufsnCxfRbbFa5FJDlFlG/iezSHzFTckxlR/uD/KGtj6N zYS3Ip1zyKo0pM38eIgvHDzU3GwVGnoivOK/7j02CcPTHl6SxSzmVFLt66aLK6pRxGJo69NiVYq DTFCszBTVyPT91nQhrinaOMj9I8vDt80XfnHrpoglI5gIgMAr3YEe2Z8Bze8FIaEmUeQk014xju Iqe1JL/DyhylJMFVHtsNIgNgs73Mzzw4n1TbHmlRF7Ee3ZGC0Sv3KX8usR9lg= X-Google-Smtp-Source: AGHT+IF7VSuwlWAm02QgNj6nGf/KE1Sf5fi3Zg6t0umFUee3c+13DG9VIM3IyuKco947be6sfmeM+w== X-Received: by 2002:a05:600c:3b86:b0:477:7ae0:cd6e with SMTP id 5b1f17b1804b1-477c10c8038mr371392765e9.5.1764581300202; Mon, 01 Dec 2025 01:28:20 -0800 (PST) Received: from ?IPv6:2001:818:ea56:d000:94c4:fb0e:28f:2a8d? ([2001:818:ea56:d000:94c4:fb0e:28f:2a8d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479110b6da9sm239410085e9.0.2025.12.01.01.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 01:28:19 -0800 (PST) Message-ID: Subject: Re: [PATCH v3] iio: accel: adxl380: fix handling of unavailable "INT1" interrupt From: Nuno =?ISO-8859-1?Q?S=E1?= To: Francesco Lavra , Ramona Gradinariu , Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 01 Dec 2025 09:29:23 +0000 In-Reply-To: <20251128172138.257961-1-flavra@baylibre.com> References: <20251128172138.257961-1-flavra@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-28 at 18:21 +0100, Francesco Lavra wrote: > fwnode_irq_get_byname() returns a negative value on failure; if a negativ= e > value is returned, use it as `err` argument for dev_err_probe(). > While at it, add a missing trailing newline to the dev_err_probe() error > message. >=20 > Fixes: df36de13677a ("iio: accel: add ADXL380 driver") > Signed-off-by: Francesco Lavra > Reviewed-by: Andy Shevchenko > --- Reviewed-by: Nuno S=C3=A1 > Changes from v2 [2]: > - added missing trailing newline to the dev_err_probe() error message > =C2=A0 (Andy) > - added Andy's Reviewed-by tag > Changes from v1 [1]: > - added fix to `err` argument passed to dev_err_probe() (Andy) >=20 > [1] https://lore.kernel.org/linux-iio/20251126144624.24512-1-flavra@bayli= bre.com/T/ > [2] > https://lore.kernel.org/linux-iio/20251128140726.243005-1-flavra@baylibre= .com/T/ >=20 > =C2=A0drivers/iio/accel/adxl380.c | 6 +++--- > =C2=A01 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c > index 0cf3c6815829..6d82873357cb 100644 > --- a/drivers/iio/accel/adxl380.c > +++ b/drivers/iio/accel/adxl380.c > @@ -1728,9 +1728,9 @@ static int adxl380_config_irq(struct iio_dev *indio= _dev) > =C2=A0 st->int_map[1] =3D ADXL380_INT0_MAP1_REG; > =C2=A0 } else { > =C2=A0 st->irq =3D fwnode_irq_get_byname(dev_fwnode(st->dev), "INT1"); > - if (st->irq > 0) > - return dev_err_probe(st->dev, -ENODEV, > - =C2=A0=C2=A0=C2=A0=C2=A0 "no interrupt name specified"); > + if (st->irq < 0) > + return dev_err_probe(st->dev, st->irq, > + =C2=A0=C2=A0=C2=A0=C2=A0 "no interrupt name specified\n"); > =C2=A0 st->int_map[0] =3D ADXL380_INT1_MAP0_REG; > =C2=A0 st->int_map[1] =3D ADXL380_INT1_MAP1_REG; > =C2=A0 }