From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before module unloading
Date: Wed, 19 Apr 2023 21:15:07 +0000 [thread overview]
Message-ID: <ae4faa38-9d84-c708-8228-223ed7fc68db@nvidia.com> (raw)
In-Reply-To: <3ec250a9-54c7-3e0d-2463-f8faf15cdb58@grimberg.me>
On 4/19/23 02:44, Sagi Grimberg wrote:
>
>> Before we unload the module we should cleanup the fc resources first,
>> basically reorder the shutdown sequence to be in reverse order of the
>> setup path.
>
> If this triggers a bug, then I think it is a good idea to have a
> dedicated test that reproduces it if we are changing the default
> behavior.
>
+1
-ck
next prev parent reply other threads:[~2023-04-19 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 8:47 [PATCH blktests v2 0/2] nvme_trtype=fc fixes Daniel Wagner
2023-04-19 8:47 ` [PATCH blktests v2 1/2] nvme-rc: Cleanup fc ports in reverse order Daniel Wagner
2023-04-19 9:41 ` Sagi Grimberg
2023-04-30 10:07 ` Shinichiro Kawasaki
2023-05-03 8:12 ` Daniel Wagner
2023-04-19 8:47 ` [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before module unloading Daniel Wagner
2023-04-19 9:41 ` Chaitanya Kulkarni
2023-04-19 10:36 ` Daniel Wagner
2023-04-30 10:08 ` Shinichiro Kawasaki
2023-04-19 9:44 ` Sagi Grimberg
2023-04-19 10:42 ` Daniel Wagner
2023-04-19 10:45 ` Sagi Grimberg
2023-04-30 10:34 ` Shinichiro Kawasaki
2023-05-01 14:10 ` Sagi Grimberg
2023-05-02 6:13 ` Shinichiro Kawasaki
2023-04-19 21:15 ` Chaitanya Kulkarni [this message]
2023-04-30 10:05 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4faa38-9d84-c708-8228-223ed7fc68db@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome