From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D61AC433EF for ; Thu, 14 Apr 2022 21:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240447AbiDNVwT (ORCPT ); Thu, 14 Apr 2022 17:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232439AbiDNVwR (ORCPT ); Thu, 14 Apr 2022 17:52:17 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E51C13CDB for ; Thu, 14 Apr 2022 14:49:51 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id f5so3920916ilj.13 for ; Thu, 14 Apr 2022 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q0JHKXPIUQwXKIyQID2uNw8AWiNJuyCq0B2NuHEUdjw=; b=dv9D5fNYDGcObkc1VhdDNV3GXjucyxDSnq8AFxBOd4Ons3E2R04iKBRBObfrlte5Xd KWo1msVoXlM72zJxXJj9OjCnEHb5QPDwTL8l5vZsIwbhhOdEp0nriEZ20xAt/MT7H61x oPJ5/FMYlbmLuywl6Jyn2lT+zDeQzb5mhxNhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q0JHKXPIUQwXKIyQID2uNw8AWiNJuyCq0B2NuHEUdjw=; b=5MozBL7WKIDciSEdg7/nNlR1lLCrhHqBKVYozYKTV2UkNAbFD0y9aM5Uwi7jj9kBlX ZjCzYtQzg2j9PG0ZzppjH1nVNkFtwxyZiVn71PD1piI2dJkKpsiEcmUrteQ/+OHkTgFt 34Kyi84SDnWQOBW6sDi9kAaWGeLfWI4jjdb+CvP1FOIAXY1GN0Ihu4xOyqrShDCIYJ2X zh3JyGPbtluiSXrMPE38/fFymltMlpkJuOaVJZvb1oKfxJRonMp1j2llEkIWEPi91k2n MpjCt+TCq2J6mbBb2znrPKvNqy9YU3BUrhtOqftW1aMtvPnQMvG3rfFTRkESJqyKsgOi 9IpA== X-Gm-Message-State: AOAM533FY1su4rfSxWchIHfKxQy/FD7E40OlBTyX0Ak1tCjindfkOMvX 9fVwQFhVOYQ85/1q6Gqq1KfZnw== X-Google-Smtp-Source: ABdhPJxzMy3EDhRCosc7hcDTPIL3RBmm5BQ8HqWic0WC9oy4qeJYkXOIMPf9IS63ZcjhoaqKzpnvXg== X-Received: by 2002:a92:6c08:0:b0:2c6:123f:48c9 with SMTP id h8-20020a926c08000000b002c6123f48c9mr1972848ilc.22.1649972990653; Thu, 14 Apr 2022 14:49:50 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id v11-20020a92d24b000000b002caacf87598sm1657423ilg.1.2022.04.14.14.49.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 14:49:50 -0700 (PDT) Subject: Re: [PATCH 4/4] selftest/vm: add skip support to mremap_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220414171529.62058-1-sidhartha.kumar@oracle.com> <20220414171529.62058-5-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Thu, 14 Apr 2022 15:49:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220414171529.62058-5-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/22 11:15 AM, Sidhartha Kumar wrote: > Allow the mremap test to be skipped due to errors > such as failing to find a valid remap region and > failure to parse the mmap_min_addr sysctl. > > Signed-off-by: Sidhartha Kumar > --- > tools/testing/selftests/vm/run_vmtests.sh | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 88e15fbb5027..eae98f5de2cc 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -272,11 +272,16 @@ echo "-------------------" > echo "running mremap_test" > echo "-------------------" > ./mremap_test > -if [ $? -ne 0 ]; then > +ret_val=$? > + > +if [ $ret_val -eq 0 ]; then > + echo "[PASS]" > +elif [ $ret_val -eq $ksft_skip ]; then > + echo "[SKIP]" > + exitcode=$ksft_skip > +else > echo "[FAIL]" > exitcode=1 > -else > - echo "[PASS]" > fi > > echo "-----------------" > Thank you. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah