From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F091B3054F8 for ; Mon, 3 Nov 2025 18:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762193692; cv=none; b=cHntqSh48klt9nkzGMUg4gut/keeqWulEda0MDY8rw+72f1tUddGy2reHqq6ZCrYlxgewLjzgQ1aIFA2cryJUciKx9Nj3EyCveCovWPCcP+pbqXJtFd+/doI2q2yc66+cUWEziC6eZho5qnQH00BTTrpd3mDysUFFAnrVc8AT+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762193692; c=relaxed/simple; bh=kRTldSDOu/FvTKTFbdBYsuhbuom+HjOyiUNQvk5adZg=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jufkaZLXavKaoq28yo4QYSGbNzO1J3EAr2cttjXerjvwJu79Zcziz9e98uE70BmHdPTSYtH3vbBZ4pNDBdnfSWz3BMKfSpQ5ggaUqMfYFYuv+GTXZsPgtmBlZBZCeVXY2+k37qPoOoVQ3jJerU8BKQ8ikqScgB6Z9B4lJFu5uoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HAMAqmBt; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HAMAqmBt" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-29524abfba3so32854525ad.1 for ; Mon, 03 Nov 2025 10:14:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762193690; x=1762798490; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=WfDeb7baff6ASohW/ana1Q5tLYqMzwgelS8O0alrjlo=; b=HAMAqmBt4/tW/z0+MrFMaBBudEbDpy7sjg7GZMUujq9GQPuxYEQljr+zVPEA9YmZoN SpOtPk50ah4//z5+7olymLmbIprbn9HKhHxREmQOwkJ8D6A9y0yhdaj7Cs4jCjdWiuMG ZcyU+G+aYUq9dA83+4iYFA6jlBRka5cb8kiVefNAAV1CWIzD0IOAi3n76DrcayFFWqnQ 6/QxrHZSvnMptPIHTqqGAB1dG9pCBPfdgOUFGMrtfn5o8D55TvozQCNg3z116y1EbKPO glSeWp53qfc+2or0HsiXxAwnR+uhvoHznKspyH/MGqVxbbadYJL7GYlFbO+G85eKdXqP mecw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762193690; x=1762798490; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WfDeb7baff6ASohW/ana1Q5tLYqMzwgelS8O0alrjlo=; b=ndmxcY5Cp6773k2PBwxsvfL/ZGBmnEk6didVGKcJlRS3u2SHHaYcdZfQDdIIsl6CFq ovGoLgVI5n/hciN8ZgsGVZt/RUN2E/gkImF4m2DkvhKUZSZQ3TgNGCtkG0d8D4dOzXrq uDEqlTiMSfDcGDR/75RtlpsjHAXB51UJwrmTS9yffSEZNoU+0nYAA8WaRaWLZqMhFVBx unBTvERdBKGXHNjYTk2sYqSnfPPB55krpCMG8XeTW/evc7BFmHbFXMtPkqjM8fVgvAiP SO+BIAReGScDHtd4z9XJhep2JMSvfejZNnOxcPpRkBpmHHIiI+Nala0zt6WFCctNCf5r KfGw== X-Forwarded-Encrypted: i=1; AJvYcCUtBCtcJvtPtr/5bsSWq8WSqT1jPimI2bb+FVi2cIrlwA+pX6vDDRS4Np+4ubsW54Rbm/RUO1C5T0ADKJc=@vger.kernel.org X-Gm-Message-State: AOJu0YzAZBiTxmeK28OZgtmBxMTiPxZET4pvOQV1KCdOZOUNq4lvCP82 2S21vVKj3uOZqveNLy9LOmcTdoj0BwBUHt7/uvBjr6oBBL17ejQ9+0Bn X-Gm-Gg: ASbGnctLkKHHtFtYG8QKwTzAfHFKxPXfH0SH0SGOzRS07vwVFgBChZx6ZUPcDb3pe93 dB/bEHF5CY8VczVtqJU4alNo6THIHwWNRtb74exb/3YCt4WyMMEpYx/KE88m0UMuPu26CNWUp2L Z0vtxeqaBQKTDfs5pwUFf4l+Z4Mx4hKu3EliD4H+83X3hLTBBpOpyMPVwveMT6NEv3NB4PRksbe ALvhyZm/MG1rtcBA4/KPWxqjrt4Muhvjdshq2wECzGbZF2NQE6198IbHjmpqZ/dbuEvkQSjS/ID eAmzGvon5xP0kETeJFS4C+7W8I7tgprQZ/GkW8pV9caRx8EAEmlZejI+IDtC3ydxrUEnhJqz+CU v6FXwAAHVo/Yr6vS4AUZxxepMtvlhS4l1MLDoctmSKWI84rEJDc6IpYnBCjMJGI6hQtCNrns3yE 9tkoRv9ksgYE6DTjpnybXjRZPEy+AIuoEwszQ9 X-Google-Smtp-Source: AGHT+IFj6on1DpKDZ6l6GB/KDZKBx7WGs07I/oEK6+7I8XTKoEXeIEIYlTAWE0TZSKyMOsESiOQzAw== X-Received: by 2002:a17:902:c406:b0:24b:25f:5f81 with SMTP id d9443c01a7336-2951a3eacaamr206673065ad.17.1762193690274; Mon, 03 Nov 2025 10:14:50 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:3eb6:963c:67a2:5992? ([2620:10d:c090:500::5:d721]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3415c8b5cfcsm1740053a91.19.2025.11.03.10.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 10:14:49 -0800 (PST) Message-ID: Subject: Re: [PATCH bpf-next v4 2/2] selftests/bpf: Add test for conditional jumps on same scalar register From: Eduard Zingerman To: KaFai Wan , ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, paul.chaignon@gmail.com, m.shachnai@gmail.com, harishankar.vishwanathan@gmail.com, colin.i.king@gmail.com, luis.gerhorst@fau.de, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Mon, 03 Nov 2025 10:14:47 -0800 In-Reply-To: <20251103063108.1111764-3-kafai.wan@linux.dev> References: <20251103063108.1111764-1-kafai.wan@linux.dev> <20251103063108.1111764-3-kafai.wan@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2025-11-03 at 14:31 +0800, KaFai Wan wrote: > Add test cases to verify the correctness of the BPF verifier's branch ana= lysis > when conditional jumps are performed on the same scalar register. And mak= e sure > that JGT does not trigger verifier BUG. >=20 > Signed-off-by: KaFai Wan > --- Thank you for adding these. Acked-by: Eduard Zingerman (but a comment needs a fix) [...] > +SEC("socket") > +__description("jset on same register, scalar value unknown branch 3") > +__msg("4: (b7) r0 =3D 0 {{.*}} R0=3D0") > +__msg("6: (b7) r0 =3D 1 {{.*}} R0=3D1") > +__success __log_level(2) > +__flag(BPF_F_TEST_REG_INVARIANTS) > +__naked void jset_on_same_register_5(void *ctx) > +{ > + asm volatile(" \ > + /* range [-1;-1] */ \ ^^ Typo, should be [-1;1]. > + call %[bpf_get_prandom_u32]; \ > + r0 &=3D 0x2; \ > + r0 -=3D 1; \ > + if r0 & r0 goto l1_%=3D; \ > +l0_%=3D: r0 =3D 0; \ > + exit; \ > +l1_%=3D: r0 =3D 1; \ > + exit; \ > +" : > + : __imm(bpf_get_prandom_u32) > + : __clobber_all); > +} > + > char _license[] SEC("license") =3D "GPL";