From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 829ABC54FCB for ; Sun, 26 Apr 2020 17:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62BE2206DD for ; Sun, 26 Apr 2020 17:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726182AbgDZRxK (ORCPT ); Sun, 26 Apr 2020 13:53:10 -0400 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:40336 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726151AbgDZRxK (ORCPT ); Sun, 26 Apr 2020 13:53:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 69AA75DE1; Sun, 26 Apr 2020 17:53:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: eye08_558d5011d7757 X-Filterd-Recvd-Size: 2129 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Sun, 26 Apr 2020 17:53:07 +0000 (UTC) Message-ID: Subject: Re: [PATCH] drm/radeon: cleanup coding style a bit From: Joe Perches To: Christian =?ISO-8859-1?Q?K=F6nig?= , Bernard Zhao , Alex Deucher , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com Date: Sun, 26 Apr 2020 10:53:06 -0700 In-Reply-To: <2c67e29b-df17-6ae3-cb55-af950acc022c@amd.com> References: <20200426131244.22293-1-bernard@vivo.com> <2c67e29b-df17-6ae3-cb55-af950acc022c@amd.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-04-26 at 15:18 +0200, Christian König wrote: > Am 26.04.20 um 15:12 schrieb Bernard Zhao: > > Maybe no need to check ws before kmalloc, kmalloc will check > > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just > > return > > > > Signed-off-by: Bernard Zhao > > Reviewed-by: Christian König > > I'm wondering why the automated scripts haven't found that one before. because this pattern is if (foo) kfree(bar); and the pattern looked for is: if (foo) kfree(foo); > > diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c [] > > @@ -1211,8 +1211,7 @@ static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32 > > SDEBUG("<<\n"); > > > > free: > > - if (ws) > > - kfree(ectx.ws); > > + kfree(ectx.ws); > > return ret; > > } I'm wondering if this removal is correct as the function is named _locked and it may be recursive or called under some external lock.