From: "guanxun mu" <lyxmoo@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] AS apple talk protocol register_snap_client failed
Date: Fri, 14 Dec 2007 14:03:05 +0800 [thread overview]
Message-ID: <ae65fe130712132203u6d77cf3h9d0265bb37da9574@mail.gmail.com> (raw)
[PACTH APPLETALK]
This patch update proto_init process when register_snap_client failed
Signed-off-by: Michale Moore <lyxmoo@gmail.com>
diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
index 6c5c6dc..d6573f6 100644
--- a/net/appletalk/aarp.c
+++ b/net/appletalk/aarp.c
@@ -873,7 +873,10 @@ void __init aarp_proto_init(void)
{
aarp_dl = register_snap_client(aarp_snap_id, aarp_rcv);
if (!aarp_dl)
- printk(KERN_CRIT "Unable to register AARP with SNAP.\n");
+ {
+ printk(KERN_CRIT "Unable to register AARP with SNAP.\n");
+ return;
+ }
init_timer(&aarp_timer);
aarp_timer.function = aarp_expire_timeout;
aarp_timer.data = 0;
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index e0d37d6..ce9929c 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1894,9 +1894,9 @@ static int __init atalk_init(void)
(void)sock_register(&atalk_family_ops);
ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv);
- if (!ddp_dl)
- printk(atalk_err_snap);
-
+ if (!ddp_dl)
+ goto failed;
+
dev_add_pack(<alk_packet_type);
dev_add_pack(&ppptalk_packet_type);
@@ -1906,7 +1906,13 @@ static int __init atalk_init(void)
atalk_register_sysctl();
out:
return rc;
+failed:
+ printk(atalk_err_snap);
+ sock_unregister(PF_APPLETALK);
+ proto_unregister(&ddp_proto);
+ return -1;
}
+
module_init(atalk_init);
/*
next reply other threads:[~2007-12-14 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 6:03 guanxun mu [this message]
2007-12-14 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae65fe130712132203u6d77cf3h9d0265bb37da9574@mail.gmail.com \
--to=lyxmoo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome