mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Chengci . Xu" <chengci.xu@mediatek.com>,
	Yong Wu <yong.wu@mediatek.com>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8188: Fix IOMMU device for rdma0
Date: Tue, 8 Apr 2025 12:09:54 +0200	[thread overview]
Message-ID: <ae6b9a80-c8b6-48dc-9229-da4e8c102551@collabora.com> (raw)
In-Reply-To: <20250408092303.3563231-1-wenst@chromium.org>

Il 08/04/25 11:23, Chen-Yu Tsai ha scritto:
> Based on the comments in the MT8188 IOMMU binding header, the rdma0
> device specifies the wrong IOMMU device for the IOMMU port it is
> tied to:
> 
>      This SoC have two MM IOMMU HWs, this is the connected information:
>      iommu-vdo: larb0/2/5/9/10/11A/11C/13/16B/17B/19/21
>      iommu-vpp: larb1/3/4/6/7/11B/12/14/15/16A/17A/23/27
> 
> rdma0's endpoint is M4U_PORT_L1_DISP_RDMA0 (on larb1), which should use
> iommu-vpp, but it is currently tied to iommu-vdo.
> 
> Somehow this went undetected until recently in Linux v6.15-rc1 with some
> IOMMU subsystem framework changes that caused the IOMMU to no longer
> work. The IOMMU would fail to probe if any devices associated with it
> could not be successfully attached. Prior to these changes, only the
> end device would be left without an IOMMU attached.
> 
> Fixes: 7075b21d1a8e ("arm64: dts: mediatek: mt8188: Add display nodes for vdosys0")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>




  reply	other threads:[~2025-04-08 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08  9:23 Chen-Yu Tsai
2025-04-08 10:09 ` AngeloGioacchino Del Regno [this message]
2025-04-10  9:50 ` Jason-JH Lin (林睿祥)
2025-04-14  9:53 ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae6b9a80-c8b6-48dc-9229-da4e8c102551@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=chengci.xu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=wenst@chromium.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®