From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 3.mo561.mail-out.ovh.net (3.mo561.mail-out.ovh.net [46.105.44.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9273A900C for ; Wed, 21 Jan 2026 10:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.105.44.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768992585; cv=none; b=J1o7GmQ2yGDwLLr0uMkGq9Hm2s5r94rX/iWYklFFa1JTCCUO8I/xJ0AdNspfRgDvvmhuLudQxHuV/RgWTi+U/EJtuNFbrEaDdzUAqvMjo/zirmd1JilbidPYt4ngN3yd9pbnMT9OpEfLc/rAHlMfyJsI9OlD7sB4TN+fuampUjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768992585; c=relaxed/simple; bh=fOxKTQFe4ljMGp79XJjZgYxbrcLjDHYU36G8ZSc2FN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IlAM2aqellLYuxrSdSI9KLf0FyG9CzhrEuNj7T6lNKqQt8ZmYqiysfJSRMpwBnLQczxyigU4S2hjPnzTuWhOcGa1zYs8OUipVd2Ra99/92+EpQU53sFp9pVGRJaI2e7f4lakEn+DxASm/V9uf/brFoFckzaFu2ZUrZGRZ5WA2Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=formalgen.com; spf=pass smtp.mailfrom=formalgen.com; dkim=pass (2048-bit key) header.d=formalgen.com header.i=@formalgen.com header.b=A5p+NM2x; arc=none smtp.client-ip=46.105.44.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=formalgen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=formalgen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=formalgen.com header.i=@formalgen.com header.b="A5p+NM2x" Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.254.29]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4dx11H3wN8z6TSX for ; Wed, 21 Jan 2026 10:40:19 +0000 (UTC) Received: from ghost-submission-7d8d68f679-kmlcg (unknown [10.110.188.199]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 1356980EF3; Wed, 21 Jan 2026 10:40:08 +0000 (UTC) Received: from formalgen.com ([37.59.142.106]) by ghost-submission-7d8d68f679-kmlcg with ESMTPSA id /6EgNQetcGnXbQcANTVUFQ (envelope-from ); Wed, 21 Jan 2026 10:40:08 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-106R0063f0a960b-d8ed-49e4-846f-7e96fa17dd7c, 831801AFC7761530D51FB11603EF4B8E66579AB0) smtp.auth=david.desobry@formalgen.com X-OVh-ClientIp:90.91.42.105 Message-ID: Date: Wed, 21 Jan 2026 11:40:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/lib: Optimize num_digits() and fix INT_MIN overflow To: David Laight Cc: "H. Peter Anvin" , tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <20260120174748.302078-1-david.desobry@formalgen.com> <20260120214612.73b83cbe@pumpkin> <8923623d-1a23-483d-add7-2fd03a3a2c3d@zytor.com> <20260121095405.58fa513f@pumpkin> Content-Language: en-US From: David Desobry In-Reply-To: <20260121095405.58fa513f@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 12468215569986341851 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: dmFkZTGJx17BzeBB4OmDYeGI1zp/sbQzeu9BGHHEOKyBx40BXQwRz4RUB52+pwDo/p4SdSniiL1baAXxuRdfm0BPjTPZd2a/0/Gh9ZSXKg2Ig1la6TNdW45jFh9zN6aiaJCNLGjdNkYf8yrnD7xm2ghXAJGZjXMBe+1X+noRnNknMeY0FAwcmyKbeXM9YHc5phRXm2Zn7dOeJ5mB62gsyUK5q3N1EY/0U6j1vYEk7p7une5RtDkWlspsA4CY9WGof0EL6h36bBrxWWNpCLZMx8Cav7khBaR2Ljo7uU8g/l8SVltKT2i5N/MFaJHwo4uVfUmKTw5wuZ+JWs/FdRTw1af+zwYzq8dVNQLvLv87geunY2guMNHcbOuy2cFqN5+FJEL21gnxeFmEl8K3hp5wLM25AamRy0631NiJW8cejibxlm9VAslxvqxmlPRQTrQHqxkFAmxwg0Ix1B1ZUVRZrdLdGo3hvI8l3xqDsUy61s8PNJgDJLTrQVi6vMlIpAOlt9ZDyEHWMApRnROYXEiVfHWBdMlWnED3gOtWvP8YYpbDPmuCLhO+3vWv8Je3dgv4Fv1Mlds4R9UgHdz+DYg7AycysCgu6WyHoctp55m5AONtd+WjYLHZ8LPo1cF6vfhm0MlV21fv+dxnYeMJ3DjKkwbbEVbpY+k5LzC+oyJqoP+1/8ww9Q DKIM-Signature: a=rsa-sha256; bh=cykcYg4+6otMaI3tn543b2fT4wuyaw49dsfdMyWcCac=; c=relaxed/relaxed; d=formalgen.com; h=From; s=ovhmo-selector-1; t=1768992019; v=1; b=A5p+NM2x/OvhXn7Cnk46K6EvG/FN/g3DAnZYMiNbMiGVcNyzgMYPjX+Ps3ba8zzPFDCbozgR degglqgF0VA/EHdIM0mXQXmLIov+WG26hNmcZDP8PKCLtytAEM3us8q0uDInvIOGuHwa4p6/dg3 3CZhf0W5cgnVKQbZ61uTOJInaIkeE4cLHNGQGs4+qcLWiLkfcLOO27FEyYdVl4fQfsjTsz41VHH 5a1ioteoxy6FBOmyWSTaDKxci2p5ikrKEWCVFy9UO+0HJJDAsEW30eJDjTQNYlv2fXFwpzEWKvI LOjRTn22wv00VwArzpGpaah1730QI1XLE2fTvTnSxPvdw== On 1/21/26 10:54, David Laight wrote: >> I'm not familiar enough with the rest of the codebase to know if >> changing the function signature to unsigned int is correct here. > > In theory you'd need to change the name and all the callers. > > David > > Agreed. It turns out there were very few callers. I have just submitted V5, which renames the function to num_digits_u32(), switches the interface to unsigned int, and updates all callers accordingly. David