From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC44CC43219 for ; Tue, 25 Jan 2022 20:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232763AbiAYUxI (ORCPT ); Tue, 25 Jan 2022 15:53:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232695AbiAYUwj (ORCPT ); Tue, 25 Jan 2022 15:52:39 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D351C06173B for ; Tue, 25 Jan 2022 12:52:39 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id i62so9527055ioa.1 for ; Tue, 25 Jan 2022 12:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/uOHuMBWIqzsPRu5jrm/RXJrpyoE9KrZzrG0nDPUmUQ=; b=JA+X+D2+jQGjPHUgwaZzAw+G+IQHrce37PdG/w1rApmU3BRC+yo8W8Xt69hHa3+5Nn hnu9oK6xriVCICmj+Nqb5d/iCrD3X3jdE4DyRwouIhxfexMlkg7AniiMN8p6YVmMPFtF 6fL2JBp5Q8l3cbo5zDPEc0mPpMzonGORnkZfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/uOHuMBWIqzsPRu5jrm/RXJrpyoE9KrZzrG0nDPUmUQ=; b=psRB8p3ftCRE68qrIPPiFneExiDZASSpX5uuV0LL4iTVn3f/c2/+vjEjbjdDCkE8CA yL5yqFeyCeenhchryU2CqjINUxIgrx2KjqGwcH5fUOBfhTroiOV5yjDSmSBxIxEKqm3z aWVE4ba6PbVzMfyyQHFk1FAvKCBmpirBEA19/OnZuNalZYmADzWzRsurghDdAyvTc/+w TIu6769zyVp1+DnM5CUbT+2sKe/XCz4ex6gOxetWrAsMUP6K1lZoqHxpdA5gW8zVd74D V8zGSUdFURVAJE51np3ldltc2QtvXMg/qhsv6JPABqv+hs56yGoZ/qZlb2jiFe5bCPol u7Lg== X-Gm-Message-State: AOAM532AJDdLcgdrjRfdLyXK9ova01IBK/6gTXLH6EhGrflijDwwFG2w jA9MYwtsaMVwmPGKPy8XuX/8iw== X-Google-Smtp-Source: ABdhPJxN5vxdRGXKizCDaf0QNPFfb9X1rWosGXVW7lkFLPqOqM7d9XyixC0OdcgYRCUYQrxNgJtUsA== X-Received: by 2002:a6b:8d42:: with SMTP id p63mr7839784iod.27.1643143958887; Tue, 25 Jan 2022 12:52:38 -0800 (PST) Received: from ?IPv6:2601:282:8200:4c:4ef8:d404:554b:9671? ([2601:282:8200:4c:4ef8:d404:554b:9671]) by smtp.gmail.com with ESMTPSA id e17sm9299318ilm.67.2022.01.25.12.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 12:52:38 -0800 (PST) Subject: Re: [PATCH v2] selftests: rtc: Increase test timeout so that all tests run To: Alexandre Belloni , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Shuah Khan , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Shuah Khan References: <20220112194142.3276385-1-nfraprado@collabora.com> From: Shuah Khan Message-ID: Date: Tue, 25 Jan 2022 13:52:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/12/22 4:51 PM, Shuah Khan wrote: > On 1/12/22 1:22 PM, Alexandre Belloni wrote: >> On 12/01/2022 14:41:42-0500, Nícolas F. R. A. Prado wrote: >>> The timeout setting for the rtc kselftest is currently 90 seconds. This >>> setting is used by the kselftest runner to stop running a test if it >>> takes longer than the assigned value. >>> >>> However, two of the test cases inside rtc set alarms. These alarms are >>> set to the next beginning of the minute, so each of these test cases may >>> take up to, in the worst case, 60 seconds. >>> >>> In order to allow for all test cases in rtc to run, even in the worst >>> case, when using the kselftest runner, the timeout value should be >>> increased to at least 120. Set it to 180, so there's some additional >>> slack. >>> >>> Correct operation can be tested by running the following command right >>> after the start of a minute (low second count), and checking that all >>> test cases run: >>> >>>     ./run_kselftest.sh -c rtc >>> >>> Signed-off-by: Nícolas F. R. A. Prado >> Acked-by: Alexandre Belloni > > Thank you both. Will apply this for 5.17-rc2 once the merge window > closes. > Applied to linux-kselftest fixes branch for rc2/rc3 thanks, -- Shuah