From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>, <nm@ti.com>,
<vigneshr@ti.com>, <afd@ti.com>, <kristo@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <u-kumar1@ti.com>,
<danishanwar@ti.com>, <srk@ti.com>
Subject: Re: [PATCH v3 2/7] arm64: dts: ti: k3-j722s-main: Redefine USB1 node description
Date: Tue, 28 May 2024 18:07:43 +0530 [thread overview]
Message-ID: <ae766f18-3b56-4667-837b-eb51694106a4@ti.com> (raw)
In-Reply-To: <f52d9569-a399-422f-9cf0-b0bf69b64d18@kernel.org>
On Tue, May 28, 2024 at 03:15:53PM +0300, Roger Quadros wrote:
>
>
> On 24/05/2024 12:05, Siddharth Vadapalli wrote:
> > From: Ravi Gunasekaran <r-gunasekaran@ti.com>
> >
> > USB1 controller on J722S and AM62P are from different vendors.
> > Redefine the USB1 node description for J722S by deleting the
> > node inherited from AM62P dtsi.
> >
> > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> > ---
> > v2:
> > https://lore.kernel.org/r/20240513114443.16350-3-r-gunasekaran@ti.com/
> > No changes since v2.
> >
> > v1:
> > https://lore.kernel.org/r/20240429120932.11456-3-r-gunasekaran@ti.com/
> > Changes since v1:
> > - The entire node which was added in k3-j722s.dtsi in v1 in now moved to
> > k3-j722s-main.dtsi as USB is a main domain peripheral.
> > - Used generic node names - renamed "cdns-usb@f920000" to "usb@f920000".
> >
> > arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 39 +++++++++++++++++++++++
> > 1 file changed, 39 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> > index 0dac8f1e1291..b069cecebfd9 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> > @@ -6,6 +6,13 @@
> >
> > #include <dt-bindings/phy/phy-ti.h>
> >
> > +/*
> > + * USB1 controller on AM62P and J722S are of different IP.
> > + * Delete AM62P's USBSS1 node definition and redefine it for J722S.
> > + */
> > +
> > +/delete-node/ &usbss1;
> > +
>
> This is odd and indicates issues with current DT file inclusion.
> We need to split out the non common IPs (e.g. USB) out of the common k3-am62p-main.dtsi file Maybe call it k3-am62-main-common.dtsi.
> Only keep am62p specific stuff in k3-am62p-main.dtsi.
>
> Include k3-am62-main-common.dtsi and k3-am62p-main.dtsi for AM62P
> Include k3-am62-main-common.dtsi and k3-j722s-main.dtsi for J722S
>
> This way you don't need to call /delete-node/
Ok. I will move the common nodes between k3-am62p-main.dtsi and
k3-j722s-main.dtsi to "k3-am62p-j722s-common.dtsi".
Regards,
Siddharth.
next prev parent reply other threads:[~2024-05-28 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 9:05 [PATCH v3 0/7] Add PCIe and USB device-tree support for J722S Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 1/7] arm64: dts: ti: k3-j722s-main: Add support for SERDES0 Siddharth Vadapalli
2024-05-28 12:09 ` Roger Quadros
2024-05-28 12:30 ` Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 2/7] arm64: dts: ti: k3-j722s-main: Redefine USB1 node description Siddharth Vadapalli
2024-05-28 12:15 ` Roger Quadros
2024-05-28 12:37 ` Siddharth Vadapalli [this message]
2024-05-24 9:05 ` [PATCH v3 3/7] arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1 Siddharth Vadapalli
2024-05-28 12:18 ` Roger Quadros
2024-05-28 12:40 ` Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 4/7] arm64: dts: ti: k3-serdes: Add Serdes1 lane-muxing macros for J722S Siddharth Vadapalli
2024-05-28 12:19 ` Roger Quadros
2024-05-28 12:40 ` Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 5/7] arm64: dts: ti: k3-j722s: Add lane mux for Serdes1 Siddharth Vadapalli
2024-05-28 12:23 ` Roger Quadros
2024-05-28 12:42 ` Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 6/7] arm64: dts: ti: k3-j722s-main: Add WIZ1 and Serdes1 nodes Siddharth Vadapalli
2024-05-28 12:24 ` Roger Quadros
2024-05-28 12:43 ` Siddharth Vadapalli
2024-05-24 9:05 ` [PATCH v3 7/7] arm64: dts: ti: k3-j722s: Add support for PCIe0 Siddharth Vadapalli
2024-05-28 12:26 ` Roger Quadros
2024-05-28 12:44 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae766f18-3b56-4667-837b-eb51694106a4@ti.com \
--to=s-vadapalli@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®