From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Heemeryck <nicolas.heemeryck@devialet.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bindings: regulator: pca9450: Add LOADSW regulator
Date: Fri, 17 Mar 2023 12:49:43 +0100 [thread overview]
Message-ID: <ae7c1d45-8e19-dc96-6769-c0b37791132d@kernel.org> (raw)
In-Reply-To: <20230317093911.1254530-3-nicolas.heemeryck@devialet.com>
On 17/03/2023 10:39, Nicolas Heemeryck wrote:
> Add the binding documentation for the load switch regulator.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed important mailing lists as well, thus patch won't be tested.
That's a NAK. :(
>
> Signed-off-by: Nicolas Heemeryck <nicolas.heemeryck@devialet.com>
> ---
> .../bindings/regulator/nxp,pca9450-regulator.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index 835b53302db8..064d57256aff 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -20,6 +20,7 @@ description: |
> #The valid names for PCA9450 regulator nodes are:
> #BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
> #LDO1, LDO2, LDO3, LDO4, LDO5
> +#LOADSW
> #Note: Buck3 removed on PCA9450B and connect with Buck1 on PCA9450C.
>
> properties:
> @@ -74,6 +75,14 @@ properties:
>
> unevaluatedProperties: false
>
> + "LOADSW":
Does not look like pattern... unless you want something-LOADSW, but then
why?
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-17 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 9:39 [PATCH 0/2] regulator: pca9450: add " Nicolas Heemeryck
2023-03-17 9:39 ` [PATCH 1/2] regulator: pca9450: Add " Nicolas Heemeryck
2023-03-17 9:39 ` [PATCH 2/2] bindings: " Nicolas Heemeryck
2023-03-17 11:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae7c1d45-8e19-dc96-6769-c0b37791132d@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.heemeryck@devialet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®